Make V4GetHashProtocolManager::RegisterFactory safe.

components/safe_browsing_db/v4_get_hash_protocol_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/safe_browsing_db/v4_get_hash_protocol_manager.h"
 
 #include <utility>
 
 #include "base/base64.h"
 #include "base/macros.h"
@@ skipping 104 matching lines @@
       url_fetcher_id_(0) {
 }
 
 V4GetHashProtocolManager::~V4GetHashProtocolManager() {
   // Delete in-progress SafeBrowsing requests.
   STLDeleteContainerPairFirstPointers(hash_requests_.begin(),
                                       hash_requests_.end());
   hash_requests_.clear();
 }
 
+// static
+void V4GetHashProtocolManager::RegisterFactory(
+    std::unique_ptr<V4GetHashProtocolManagerFactory> factory) {
+  if (factory_)
+    delete factory_;
+  factory_ = factory.release();

[mattm, 2016/05/02 22:36:53]

If you do switch to passing in a unique_ptr, why not make factory_ a unique_ptr?

[Reilly Grant (use Gerrit), 2016/05/02 22:55:27]

factory_ is a global variable. It must be a primitive type.

+}
+
 std::string V4GetHashProtocolManager::GetHashRequest(
     const std::vector<SBPrefix>& prefixes,
     const std::vector<PlatformType>& platforms,
     ThreatType threat_type) {
   // Build the request. Client info and client states are not added to the
   // request protocol buffer. Client info is passed as params in the url.
   FindFullHashesRequest req;
   ThreatInfo* info = req.mutable_threat_info();
   info->add_threat_types(threat_type);
   info->add_threat_entry_types(URL_EXPRESSION);
@@ skipping 204 matching lines @@
   next_gethash_time_ = now + next;
 }
 
 GURL V4GetHashProtocolManager::GetHashUrl(const std::string& req_base64) const {
   return V4ProtocolManagerUtil::GetRequestUrl(req_base64, "encodedFullHashes",
                                               config_);
 }
 
 
 }  // namespace safe_browsing