Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 194443002: Add ViewHostMsg_DocumentDetached to SwappedOutMessages::CanSendWhileSwappedOut. (Closed)

Created:
6 years, 9 months ago by horo
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add ViewHostMsg_DocumentDetached to SwappedOutMessages::CanSendWhileSwappedOut. ViewHostMsg_DocumentDetached must be sent from the renderer process when the user leaves the page which is running SharedWorker. But it is not sent in the current code when the user is going to another domain page. It is because ViewHostMsg_DocumentDetached is not handled in SwappedOutMessages::CanSendWhileSwappedOut. BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/common/swapped_out_messages.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
horo
kinuko@ Please review this cl. Thank you.
6 years, 9 months ago (2014-03-11 07:33:47 UTC) #1
kinuko
lgtm
6 years, 9 months ago (2014-03-11 09:10:58 UTC) #2
horo
jochen@ Could you please review this?
6 years, 9 months ago (2014-03-11 09:16:51 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-11 14:27:19 UTC) #4
horo
The CQ bit was checked by horo@chromium.org
6 years, 9 months ago (2014-03-11 15:26:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/194443002/1
6 years, 9 months ago (2014-03-11 15:28:19 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 21:53:05 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=279725
6 years, 9 months ago (2014-03-11 21:53:06 UTC) #8
horo
The CQ bit was checked by horo@chromium.org
6 years, 9 months ago (2014-03-11 22:41:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/194443002/1
6 years, 9 months ago (2014-03-11 22:48:52 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 04:36:19 UTC) #11
Message was sent while issue was closed.
Change committed as 256422

Powered by Google App Engine
This is Rietveld 408576698