Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1944323002: [compiler] Move inline function tracing to Crankshaft. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Move inline function tracing to Crankshaft. This moves all the machinery for tracing inlined function that is specific to Crankshaft into the appropriate component. Only the old side-channel via a list of InlinedFunctionInfo structs remained within the CompilationInfo for now. In the long run we will reconstruct that information from the deoptimization data on the code objects. R=bmeurer@chromium.org Committed: https://crrev.com/69963b4c5a63f874adb95433b78a28e819fba99c Cr-Commit-Position: refs/heads/master@{#36068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -95 lines) Patch
M src/compiler.h View 1 chunk +1 line, -8 lines 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 5 chunks +55 lines, -7 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/crankshaft/lithium-codegen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/lithium-codegen.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-04 13:50:41 UTC) #3
Benedikt Meurer
Nice. LGTM.
4 years, 7 months ago (2016-05-04 17:41:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944323002/1
4 years, 7 months ago (2016-05-06 08:51:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 09:22:00 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 09:23:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69963b4c5a63f874adb95433b78a28e819fba99c
Cr-Commit-Position: refs/heads/master@{#36068}

Powered by Google App Engine
This is Rietveld 408576698