Issue 1944293003: Fix accessing private members on extension classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1944293003: Fix accessing private members on extension classes. (Closed)

Created:
4 years, 7 months ago by Bob Nystrom

Modified:
4 years, 7 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix accessing private members on extension classes. Since the member was already a symbol, canonicalMember() was incorrectly double wrapping it. Fixes #508. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/64a702c8edb9f23181ca405c2c3a02c1274c0fc6

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -0 lines)			Patch
M	lib/runtime/dart_sdk.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/codegen/lib/html/private_extension_member_test.dart	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	tool/input_sdk/private/ddc_runtime/classes.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

4 years, 7 months ago (2016-05-04 22:04:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
64a702c8edb9f23181ca405c2c3a02c1274c0fc6 (presubmit successful).