Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: runtime/vm/precompiler.cc

Issue 1944213002: Support for taking full snapshots from 'dart', not just 'dart_bootstrap'. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/precompiler.cc
diff --git a/runtime/vm/precompiler.cc b/runtime/vm/precompiler.cc
index b05b0bc877f0943fa93c2e0c343378ba2ebab53a..21e65582e0779252f2b22153686c06f12cd2c895 100644
--- a/runtime/vm/precompiler.cc
+++ b/runtime/vm/precompiler.cc
@@ -229,7 +229,13 @@ void Precompiler::DoCompileAll(
zone_ = NULL;
}
- intptr_t dropped_symbols_count = Symbols::Compact(I);
+ intptr_t symbols_before = -1;
+ intptr_t symbols_after = -1;
+ intptr_t capacity = -1;
+ Symbols::GetStats(I, &symbols_before, &capacity);
siva 2016/05/10 00:49:10 Should these two calls to Symbols::GetStats be und
rmacnak 2016/05/10 01:45:01 Done.
+ Symbols::Compact(I);
+ Symbols::GetStats(I, &symbols_after, &capacity);
+
if (FLAG_trace_precompiler) {
THR_Print("Precompiled %" Pd " functions,", function_count_);
THR_Print(" %" Pd " dynamic types,", class_count_);
@@ -237,7 +243,7 @@ void Precompiler::DoCompileAll(
THR_Print("Dropped %" Pd " functions,", dropped_function_count_);
THR_Print(" %" Pd " fields,", dropped_field_count_);
- THR_Print(" %" Pd " symbols,", dropped_symbols_count);
+ THR_Print(" %" Pd " symbols,", symbols_before - symbols_after);
THR_Print(" %" Pd " types,", dropped_type_count_);
THR_Print(" %" Pd " type arguments,", dropped_typearg_count_);
THR_Print(" %" Pd " classes,", dropped_class_count_);
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698