Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: runtime/vm/dart.cc

Issue 1944213002: Support for taking full snapshots from 'dart', not just 'dart_bootstrap'. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/dart.cc
diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc
index cd7dbde9f15319d29d4dfcf006c73250d589489d..9f7ae65312fe0deef72c01947fb9100a383ae8f5 100644
--- a/runtime/vm/dart.cc
+++ b/runtime/vm/dart.cc
@@ -226,7 +226,7 @@ const char* Dart::InitOnce(const uint8_t* vm_isolate_snapshot,
T);
const Error& error = Error::Handle(reader.ReadVmIsolateSnapshot());
if (!error.IsNull()) {
- return error.ToCString();
+ return error.ToErrorCString();
}
NOT_IN_PRODUCT(if (tds.enabled()) {
tds.SetNumArguments(2);
@@ -510,12 +510,6 @@ RawError* Dart::InitializeIsolate(const uint8_t* snapshot_buffer, void* data) {
I->heap()->PrintSizes();
MegamorphicCacheTable::PrintSizes(I);
}
- } else {
- // Populate the isolate's symbol table with all symbols from the
- // VM isolate. We do this so that when we generate a full snapshot
- // for the isolate we have a unified symbol table that we can then
- // read into the VM isolate.
- Symbols::AddPredefinedSymbolsToIsolate();
}
Object::VerifyBuiltinVtables();

Powered by Google App Engine
This is Rietveld 408576698