Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: runtime/vm/dart_api_message.cc

Issue 1944213002: Support for taking full snapshots from 'dart', not just 'dart_bootstrap'. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_message.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_message.cc
diff --git a/runtime/vm/dart_api_message.cc b/runtime/vm/dart_api_message.cc
index 182fc7db827ed87b3a0817fc444c7d8ca0d15637..2d4e759a9e96713246c1f5b25b8e654ffbbbe91c 100644
--- a/runtime/vm/dart_api_message.cc
+++ b/runtime/vm/dart_api_message.cc
@@ -416,8 +416,8 @@ Dart_CObject* ApiMessageReader::ReadInlinedObject(intptr_t object_id) {
}
-Dart_CObject* ApiMessageReader::ReadVMSymbol(intptr_t object_id) {
- ASSERT(Symbols::IsVMSymbolId(object_id));
+Dart_CObject* ApiMessageReader::ReadPredefinedSymbol(intptr_t object_id) {
+ ASSERT(Symbols::IsPredefinedSymbolId(object_id));
intptr_t symbol_id = object_id - kMaxPredefinedObjectIds;
Dart_CObject* object;
if (vm_symbol_references_ != NULL &&
@@ -433,7 +433,7 @@ Dart_CObject* ApiMessageReader::ReadVMSymbol(intptr_t object_id) {
memset(vm_symbol_references_, 0, size);
}
- object = CreateDartCObjectString(Symbols::GetVMSymbol(object_id));
+ object = CreateDartCObjectString(Symbols::GetPredefinedSymbol(object_id));
ASSERT(vm_symbol_references_[symbol_id] == NULL);
vm_symbol_references_[symbol_id] = object;
return object;
@@ -547,8 +547,8 @@ Dart_CObject* ApiMessageReader::ReadVMIsolateObject(intptr_t value) {
if (object_id == kDoubleObject) {
return AllocateDartCObjectDouble(ReadDouble());
}
- if (Symbols::IsVMSymbolId(object_id)) {
- return ReadVMSymbol(object_id);
+ if (Symbols::IsPredefinedSymbolId(object_id)) {
+ return ReadPredefinedSymbol(object_id);
}
// No other VM isolate objects are supported.
return AllocateDartCObjectNull();
« no previous file with comments | « runtime/vm/dart_api_message.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698