Add BUILD.gn for //media/ffmpeg

Add BUILD.gn for //media/ffmpeg

gn check on //media/ffmpeg/* is clean.

BUG=599578
Committed: https://crrev.com/f1d58f52c85de0009de56e3c2dc2dc2353a1a334
Cr-Commit-Position: refs/heads/master@{#392520}

[jrummell, 2016-05-03 23:49:49]

jrummell@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[jrummell, 2016-05-03 23:49:50]

PTAL. Rather than moving the ffmpeg files I've just added a BUILD.gn. WDYT?

[DaleCurtis, 2016-05-03 23:59:15]

https://codereview.chromium.org/1944183002/diff/1/media/ffmpeg/BUILD.gn
File media/ffmpeg/BUILD.gn (right):

https://codereview.chromium.org/1944183002/diff/1/media/ffmpeg/BUILD.gn#newco...
media/ffmpeg/BUILD.gn:10: allow_circular_includes_from = [ "//media/base" ]
I guess this is the magic? gn help says:

Danger

  In the above example, A's headers are likely to include headers from
  A's dependencies. Those dependencies may have public_configs that
  apply flags, defines, and include paths that make those headers work
  properly.

  With allow_circular_includes_from, B can include A's headers, and
  transitively from A's dependencies, without having the dependencies
  that would bring in the public_configs those headers need. The result
  may be errors or inconsistent builds.

  So when you use allow_circular_includes_from, make sure that any
  compiler settings, flags, and include directories are the same between
  both targets (consider putting such things in a shared config they can
  both reference). Make sure the dependencies are also the same (you
  might consider a group to collect such dependencies they both
  depend on).

Are we sure this is the case? I think so, but it's worth double checking.

[jrummell, 2016-05-05 00:23:56]

Patchset #2 (id:20001) has been deleted

[jrummell, 2016-05-05 00:26:12]

Added shared config, plus a few other changes to fix Windows compile issues.

https://codereview.chromium.org/1944183002/diff/1/media/ffmpeg/BUILD.gn
File media/ffmpeg/BUILD.gn (right):

https://codereview.chromium.org/1944183002/diff/1/media/ffmpeg/BUILD.gn#newco...
media/ffmpeg/BUILD.gn:10: allow_circular_includes_from = [ "//media/base" ]
On 2016/05/03 23:59:15, DaleCurtis wrote:
> I guess this is the magic? gn help says:
> 
> Danger
> 
>   In the above example, A's headers are likely to include headers from
>   A's dependencies. Those dependencies may have public_configs that
>   apply flags, defines, and include paths that make those headers work
>   properly.
> 
>   With allow_circular_includes_from, B can include A's headers, and
>   transitively from A's dependencies, without having the dependencies
>   that would bring in the public_configs those headers need. The result
>   may be errors or inconsistent builds.
> 
>   So when you use allow_circular_includes_from, make sure that any
>   compiler settings, flags, and include directories are the same between
>   both targets (consider putting such things in a shared config they can
>   both reference). Make sure the dependencies are also the same (you
>   might consider a group to collect such dependencies they both
>   depend on).
> 
> Are we sure this is the case? I think so, but it's worth double checking.

Done.

[DaleCurtis, 2016-05-05 01:12:09]

https://codereview.chromium.org/1944183002/diff/40001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1944183002/diff/40001/media/BUILD.gn#newcode794
media/BUILD.gn:794: "//media/ffmpeg:ffmpeg_regressiontests",
_tests

https://codereview.chromium.org/1944183002/diff/40001/media/ffmpeg/BUILD.gn
File media/ffmpeg/BUILD.gn (right):

https://codereview.chromium.org/1944183002/diff/40001/media/ffmpeg/BUILD.gn#n...
media/ffmpeg/BUILD.gn:8: assert(media_use_ffmpeg)
Just put this at the top instead in each set?

[jrummell, 2016-05-05 19:01:09]

Updated. Looks like the bots are happy.

https://codereview.chromium.org/1944183002/diff/40001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1944183002/diff/40001/media/BUILD.gn#newcode794
media/BUILD.gn:794: "//media/ffmpeg:ffmpeg_regressiontests",
On 2016/05/05 01:12:08, DaleCurtis wrote:
> _tests

Done.

https://codereview.chromium.org/1944183002/diff/40001/media/ffmpeg/BUILD.gn
File media/ffmpeg/BUILD.gn (right):

https://codereview.chromium.org/1944183002/diff/40001/media/ffmpeg/BUILD.gn#n...
media/ffmpeg/BUILD.gn:8: assert(media_use_ffmpeg)
On 2016/05/05 01:12:08, DaleCurtis wrote:
> Just put this at the top instead in each set?

Not sure how GN decides what BUILD.gn files to process. Done for now, I'll see
if the ios trybots pass.

[DaleCurtis, 2016-05-05 19:41:18]

lgtm

[jrummell, 2016-05-10 01:09:18]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-05-10 01:09:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1944183002/#ps80001
(title: "add config + rebase")

[commit-bot: I haz the power, 2016-05-10 01:09:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1944183002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1944183002/80001

[commit-bot: I haz the power, 2016-05-10 02:20:39]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-05-10 02:22:41]

Description was changed from

==========
Add BUILD.gn for //media/ffmpeg

gn check on //media/ffmpeg/* is clean.

BUG=599578
==========

to

==========
Add BUILD.gn for //media/ffmpeg

gn check on //media/ffmpeg/* is clean.

BUG=599578

Committed: https://crrev.com/f1d58f52c85de0009de56e3c2dc2dc2353a1a334
Cr-Commit-Position: refs/heads/master@{#392520}
==========

[commit-bot: I haz the power, 2016-05-10 02:22:42]

Patchset 4 (id:??) landed as
https://crrev.com/f1d58f52c85de0009de56e3c2dc2dc2353a1a334
Cr-Commit-Position: refs/heads/master@{#392520}