Unused Polymer elements script

Unused Polymer elements script

Some changes requested by dbeam in https://codereview.chromium.org/1918333005/

BUG=605823
Committed: https://crrev.com/dea6d745a2720b4fc8bc670bfdedb910bfa82bd4
Cr-Commit-Position: refs/heads/master@{#391438}

[michaelpg, 2016-05-03 21:25:54]

Description was changed from

==========
Unused Polymer elements script

Some changes requested by dbeam in https://codereview.chromium.org/1918333005/

BUG=
==========

to

==========
Unused Polymer elements script

Some changes requested by dbeam in https://codereview.chromium.org/1918333005/

BUG=605823
==========

[michaelpg, 2016-05-03 21:25:54]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org

[michaelpg, 2016-05-03 21:29:38]

PTAL; this is the same patch as the last patch at
https://codereview.chromium.org/1918333005 but this one is
based off ToT.

[Dan Beam, 2016-05-03 21:35:29]

> also, i think you're overusing @staticmethod here

[michaelpg, 2016-05-03 22:16:33]

On 2016/05/03 21:35:29, Dan Beam wrote:
> > also, i think you're overusing @staticmethod here

As I said in the other CL, I made some functions instance methods. Why is
@staticmethod bad or not useful here? (IOW, why make things member functions
when they don't have to be?)

Happy to change it, but want to learn.

[Dan Beam, 2016-05-04 02:15:14]

On 2016/05/03 22:16:33, michaelpg wrote:
> On 2016/05/03 21:35:29, Dan Beam wrote:
> > > also, i think you're overusing @staticmethod here
> 
> As I said in the other CL, I made some functions instance methods. Why is
> @staticmethod bad or not useful here? (IOW, why make things member functions
> when they don't have to be?)
> 
> Happy to change it, but want to learn.

don't care enough, lgtm

https://codereview.chromium.org/1944133002/diff/1/third_party/polymer/v1_0/fi...
File third_party/polymer/v1_0/find_unused_elements.py (right):

https://codereview.chromium.org/1944133002/diff/1/third_party/polymer/v1_0/fi...
third_party/polymer/v1_0/find_unused_elements.py:111: if (element not in
UnusedElementsDetector.__WHITELIST and
self.__WHITELIST

[michaelpg, 2016-05-04 02:57:11]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-05-04 02:57:11]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1944133002/#ps20001
(title: "self")

[michaelpg, 2016-05-04 02:57:18]

Thanks.

https://codereview.chromium.org/1944133002/diff/1/third_party/polymer/v1_0/fi...
File third_party/polymer/v1_0/find_unused_elements.py (right):

https://codereview.chromium.org/1944133002/diff/1/third_party/polymer/v1_0/fi...
third_party/polymer/v1_0/find_unused_elements.py:111: if (element not in
UnusedElementsDetector.__WHITELIST and
On 2016/05/04 02:15:14, Dan Beam wrote:
> self.__WHITELIST

Done.

[commit-bot: I haz the power, 2016-05-04 02:57:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1944133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1944133002/20001

[commit-bot: I haz the power, 2016-05-04 03:32:51]

Description was changed from

==========
Unused Polymer elements script

Some changes requested by dbeam in https://codereview.chromium.org/1918333005/

BUG=605823
==========

to

==========
Unused Polymer elements script

Some changes requested by dbeam in https://codereview.chromium.org/1918333005/

BUG=605823
==========

[commit-bot: I haz the power, 2016-05-04 03:32:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-04 03:35:06]

Description was changed from

==========
Unused Polymer elements script

Some changes requested by dbeam in https://codereview.chromium.org/1918333005/

BUG=605823
==========

to

==========
Unused Polymer elements script

Some changes requested by dbeam in https://codereview.chromium.org/1918333005/

BUG=605823

Committed: https://crrev.com/dea6d745a2720b4fc8bc670bfdedb910bfa82bd4
Cr-Commit-Position: refs/heads/master@{#391438}
==========

[commit-bot: I haz the power, 2016-05-04 03:35:07]

Patchset 2 (id:??) landed as
https://crrev.com/dea6d745a2720b4fc8bc670bfdedb910bfa82bd4
Cr-Commit-Position: refs/heads/master@{#391438}