build mini_installer as part of the chromium_builder_perf target on Windows

build mini_installer as part of the chromium_builder_perf target on Windows

I want the perf builders to build this so we can track its size.

BUG=457078
Committed: https://crrev.com/a3d3aa4d4d3bba1fae533eb88ca2fd2ef2ecf7e2
Cr-Commit-Position: refs/heads/master@{#391656}

[hans, 2016-05-03 21:11:20]

Description was changed from

==========
gyp: build mini_installer as part of the All target on Windows

The Windows builders on chromium.perf build the 'All' target. I'd like that
to include mini_installer.exe so we can track its size.

In the gn build, AFAIU, 'All' is an alias for 'gn_all', which causes everything
to be built, so there's no need to update the gn build.

BUG=457078
==========

to

==========
build mini_installer as part of the chromium_builder_perf target on Windows

I want the perf builders to build this so we can track its size.

BUG=457078
==========

[hans, 2016-05-03 21:14:54]

gn build too

[hans, 2016-05-03 21:16:21]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2016-05-03 21:16:21]

Please take a look.

I'm a little uncertain about the gn build - I couldn't find anything else
referencing mini_installer, but there is something called
next_version_mini_installer. mini_installer does seem to exist as a target,
though.

[Nico, 2016-05-03 21:20:10]

thakis@chromium.org changed reviewers:
+ gab@chromium.org, nednguyen@google.com

[Nico, 2016-05-03 21:20:11]

+nednguyen for perf target change (looks like he's out until tomorrow)

+gab for mini_installer-in-gn question

[nednguyen, 2016-05-03 22:28:20]

nednguyen@google.com changed reviewers:
+ dtu@chromium.org

[nednguyen, 2016-05-03 22:28:20]

I defer this to dtu@

[dtu, 2016-05-03 23:50:25]

https://codereview.chromium.org/1944103002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1944103002/diff/40001/BUILD.gn#newcode903
BUILD.gn:903: deps += [ "//chrome/installer/mini_installer:mini_installer" ]
Redundant "deps +="

[hans, 2016-05-03 23:53:13]

remove redundant deps+=

[hans, 2016-05-03 23:53:37]

Please take another look.

https://codereview.chromium.org/1944103002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1944103002/diff/40001/BUILD.gn#newcode903
BUILD.gn:903: deps += [ "//chrome/installer/mini_installer:mini_installer" ]
On 2016/05/03 23:50:25, dtu wrote:
> Redundant "deps +="

Done.

[dtu, 2016-05-03 23:55:47]

lgtm

[gab, 2016-05-04 17:53:25]

On 2016/05/03 21:16:21, hans wrote:
> Please take a look.
> 
> I'm a little uncertain about the gn build - I couldn't find anything else
> referencing mini_installer, but there is something called
> next_version_mini_installer. mini_installer does seem to exist as a target,
> though.

SGTM (lgtm stamp), mini_installer is the right target,
next_version_mini_installer isn't.

[hans, 2016-05-04 17:59:12]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-05-04 17:59:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1944103002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1944103002/60001

[commit-bot: I haz the power, 2016-05-04 18:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 18:10:54]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2016-05-04 18:11:40]

lgtm

[Nico, 2016-05-04 18:11:45]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-05-04 18:12:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1944103002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1944103002/60001

[commit-bot: I haz the power, 2016-05-04 18:25:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 18:25:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hans, 2016-05-04 18:27:08]

hans@chromium.org changed reviewers:
+ dpranke@chromium.org

[hans, 2016-05-04 18:27:08]

+dpranke for BUILD.gn owner's

[Dirk Pranke, 2016-05-04 22:06:13]

lgtm

[hans, 2016-05-04 22:06:30]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-05-04 22:07:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1944103002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1944103002/60001

[commit-bot: I haz the power, 2016-05-04 22:13:00]

Description was changed from

==========
build mini_installer as part of the chromium_builder_perf target on Windows

I want the perf builders to build this so we can track its size.

BUG=457078
==========

to

==========
build mini_installer as part of the chromium_builder_perf target on Windows

I want the perf builders to build this so we can track its size.

BUG=457078
==========

[commit-bot: I haz the power, 2016-05-04 22:13:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-04 22:14:57]

Description was changed from

==========
build mini_installer as part of the chromium_builder_perf target on Windows

I want the perf builders to build this so we can track its size.

BUG=457078
==========

to

==========
build mini_installer as part of the chromium_builder_perf target on Windows

I want the perf builders to build this so we can track its size.

BUG=457078

Committed: https://crrev.com/a3d3aa4d4d3bba1fae533eb88ca2fd2ef2ecf7e2
Cr-Commit-Position: refs/heads/master@{#391656}
==========

[commit-bot: I haz the power, 2016-05-04 22:14:58]

Patchset 4 (id:??) landed as
https://crrev.com/a3d3aa4d4d3bba1fae533eb88ca2fd2ef2ecf7e2
Cr-Commit-Position: refs/heads/master@{#391656}