Cleanup XFA-Specific memory allocators.

Cleanup XFA-Specific memory allocators.

Remove unused "dynamic" allocator (the scary one).
Use malloc/free wrapper allocator under #ifdef for CF/asan testing.
Rename IFX_MEMAllocator to IFX_MemoryAllocator (MEM in all caps
would imply that MEM was an acroynm, not an abbreviation).

Committed: https://pdfium.googlesource.com/pdfium/+/4d06f83da7fbc65e83ecc3c36b339c04ac1ab668

[Tom Sepez, 2016-05-03 20:34:02]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-05-03 20:34:02]

Dan, for review.  I'll undo the #define later, but for now, this will let asan
look deeper into our usage.

[dsinclair, 2016-05-03 20:43:52]

lgtm w/ nits.

https://codereview.chromium.org/1944093002/diff/1/xfa/fde/css/fde_cssdeclarat...
File xfa/fde/css/fde_cssdeclaration.cpp (right):

https://codereview.chromium.org/1944093002/diff/1/xfa/fde/css/fde_cssdeclarat...
xfa/fde/css/fde_cssdeclaration.cpp:418: IFX_MemoryAllocator* pStaticStore =
(IFX_MemoryAllocator*)pArgs->pStaticStore;
nit: static_cast

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cpp
File xfa/fgas/crt/fgas_memory.cpp (right):

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:8: 
I gather we shouldn't roll into chromium with this in place? may just want to
send a message to the channel to that effect.

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:138: if (m_pLastChunk == nullptr) {
if (!m_pLastChunk)

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:148: if (m_pLastChunk == nullptr ||
m_pLastChunk->iFreeSize < size) {
if (!m_pLastChunk

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:189: if (pChunk == nullptr) {
if (!pChunk)

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:204: while (pChunk != nullptr) {
while (pChunk)

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:210: if (pChunk == nullptr) {
if (!pChunk)

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:213: ASSERT(pChunk != nullptr);
ASSERT(pChunk)

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:226: ASSERT(pBlock != nullptr);
ASSERT(pBlock)

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:231: while (pChunk != nullptr) {
while (pChunk)

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:241: ASSERT(pChunk != nullptr);
ASSERT(pChunk)

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:251: if (pPrior == nullptr) {
if (!pPrior)

[Tom Sepez, 2016-05-03 20:59:31]

https://codereview.chromium.org/1944093002/diff/1/xfa/fde/css/fde_cssdeclarat...
File xfa/fde/css/fde_cssdeclaration.cpp (right):

https://codereview.chromium.org/1944093002/diff/1/xfa/fde/css/fde_cssdeclarat...
xfa/fde/css/fde_cssdeclaration.cpp:418: IFX_MemoryAllocator* pStaticStore =
(IFX_MemoryAllocator*)pArgs->pStaticStore;
On 2016/05/03 20:43:51, dsinclair wrote:
> nit: static_cast
Cast to superclass not required.  removed.

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cpp
File xfa/fgas/crt/fgas_memory.cpp (right):

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:8: 
On 2016/05/03 20:43:52, dsinclair wrote:
> I gather we shouldn't roll into chromium with this in place? may just want to
> send a message to the channel to that effect.

It only affects XFA, and we might just want to avoid these optimizations for a
little bit.

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:138: if (m_pLastChunk == nullptr) {
On 2016/05/03 20:43:52, dsinclair wrote:
> if (!m_pLastChunk)

Done.

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:148: if (m_pLastChunk == nullptr ||
m_pLastChunk->iFreeSize < size) {
On 2016/05/03 20:43:52, dsinclair wrote:
> if (!m_pLastChunk

Done.

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:189: if (pChunk == nullptr) {
On 2016/05/03 20:43:51, dsinclair wrote:
> if (!pChunk)

Done.

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:204: while (pChunk != nullptr) {
On 2016/05/03 20:43:52, dsinclair wrote:
> while (pChunk)

Done.

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:210: if (pChunk == nullptr) {
On 2016/05/03 20:43:52, dsinclair wrote:
> if (!pChunk)

Done.

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:213: ASSERT(pChunk != nullptr);
On 2016/05/03 20:43:52, dsinclair wrote:
> ASSERT(pChunk)

Pointless, removed.

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:226: ASSERT(pBlock != nullptr);
On 2016/05/03 20:43:52, dsinclair wrote:
> ASSERT(pBlock)
removed.

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:231: while (pChunk != nullptr) {
On 2016/05/03 20:43:52, dsinclair wrote:
> while (pChunk)

Done.

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:241: ASSERT(pChunk != nullptr);
On 2016/05/03 20:43:51, dsinclair wrote:
> ASSERT(pChunk)

Done.

https://codereview.chromium.org/1944093002/diff/1/xfa/fgas/crt/fgas_memory.cp...
xfa/fgas/crt/fgas_memory.cpp:251: if (pPrior == nullptr) {
On 2016/05/03 20:43:52, dsinclair wrote:
> if (!pPrior)

Done.

[Tom Sepez, 2016-05-03 21:00:55]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-05-03 21:00:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/1944093002/#ps40001
(title: "Dan's comments, remove more unused methods.")

[commit-bot: I haz the power, 2016-05-03 21:01:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1944093002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1944093002/40001

[commit-bot: I haz the power, 2016-05-03 21:13:33]

Description was changed from

==========
Cleanup XFA-Specific memory allocators.

Remove unused "dynamic" allocator (the scary one).
Use malloc/free wrapper allocator under #ifdef for CF/asan testing.
Rename IFX_MEMAllocator to IFX_MemoryAllocator (MEM in all caps
would imply that MEM was an acroynm, not an abbreviation).
==========

to

==========
Cleanup XFA-Specific memory allocators.

Remove unused "dynamic" allocator (the scary one).
Use malloc/free wrapper allocator under #ifdef for CF/asan testing.
Rename IFX_MEMAllocator to IFX_MemoryAllocator (MEM in all caps
would imply that MEM was an acroynm, not an abbreviation).

Committed:
https://pdfium.googlesource.com/pdfium/+/4d06f83da7fbc65e83ecc3c36b339c04ac1a...
==========

[commit-bot: I haz the power, 2016-05-03 21:13:37]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/4d06f83da7fbc65e83ecc3c36b339c04ac1a...