Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1944023002: Include all static class members in UnlinkedPublicName.members. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include all static class members in UnlinkedPublicName.members. Previously, we only included names that could be referenced from consts. This was a holdover from the initial implemenation, where summaries only needed to encode information about the expressions used in valid const declarations. Now, we also encode information about expressions needed for type inference, which can refer to any static class member. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/770ee1a74477784c228d89c14b49109d64a46d25

Patch Set 1 #

Patch Set 2 : Fix incorrect upload (previously included changes from CL 1944773002) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -39 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 5 chunks +7 lines, -19 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 4 chunks +28 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-03 18:48:03 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-03 18:49:50 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-03 19:20:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
770ee1a74477784c228d89c14b49109d64a46d25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698