Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: content/browser/frame_host/frame_navigation_entry.cc

Issue 1944013003: Move ownership of source SiteInstance to the FrameNavigationEntry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another round of review comments addressed. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/frame_navigation_entry.cc
diff --git a/content/browser/frame_host/frame_navigation_entry.cc b/content/browser/frame_host/frame_navigation_entry.cc
index 90293581b502af741c82d0e2aa98f27621b7caf9..a788c45b8b325a75727f8a352b10316bfac3128d 100644
--- a/content/browser/frame_host/frame_navigation_entry.cc
+++ b/content/browser/frame_host/frame_navigation_entry.cc
@@ -16,6 +16,7 @@ FrameNavigationEntry::FrameNavigationEntry(
int64_t item_sequence_number,
int64_t document_sequence_number,
scoped_refptr<SiteInstanceImpl> site_instance,
+ scoped_refptr<SiteInstanceImpl> source_site_instance,
const GURL& url,
const Referrer& referrer,
const std::string& method,
@@ -24,6 +25,7 @@ FrameNavigationEntry::FrameNavigationEntry(
item_sequence_number_(item_sequence_number),
document_sequence_number_(document_sequence_number),
site_instance_(std::move(site_instance)),
+ source_site_instance_(std::move(source_site_instance)),
url_(url),
referrer_(referrer),
method_(method),
@@ -34,25 +36,30 @@ FrameNavigationEntry::~FrameNavigationEntry() {
FrameNavigationEntry* FrameNavigationEntry::Clone() const {
FrameNavigationEntry* copy = new FrameNavigationEntry();
+
+ // Omit any fields cleared at commit time.
copy->UpdateEntry(frame_unique_name_, item_sequence_number_,
- document_sequence_number_, site_instance_.get(), url_,
- referrer_, page_state_, method_, post_id_);
+ document_sequence_number_, site_instance_.get(), nullptr,
+ url_, referrer_, page_state_, method_, post_id_);
return copy;
}
-void FrameNavigationEntry::UpdateEntry(const std::string& frame_unique_name,
- int64_t item_sequence_number,
- int64_t document_sequence_number,
- SiteInstanceImpl* site_instance,
- const GURL& url,
- const Referrer& referrer,
- const PageState& page_state,
- const std::string& method,
- int64_t post_id) {
+void FrameNavigationEntry::UpdateEntry(
+ const std::string& frame_unique_name,
+ int64_t item_sequence_number,
+ int64_t document_sequence_number,
+ SiteInstanceImpl* site_instance,
+ scoped_refptr<SiteInstanceImpl> source_site_instance,
+ const GURL& url,
+ const Referrer& referrer,
+ const PageState& page_state,
+ const std::string& method,
+ int64_t post_id) {
frame_unique_name_ = frame_unique_name;
item_sequence_number_ = item_sequence_number;
document_sequence_number_ = document_sequence_number;
site_instance_ = site_instance;
+ source_site_instance_ = std::move(source_site_instance);
url_ = url;
referrer_ = referrer;
page_state_ = page_state;
« no previous file with comments | « content/browser/frame_host/frame_navigation_entry.h ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698