Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Issue 1944: Fixed some arm debug issues I had missed the first time round.

Created:
12 years, 3 months ago by plesner
Modified:
9 years, 7 months ago
Reviewers:
iposva, Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fixed some arm debug issues I had missed the first time round.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/disasm-arm.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
plesner
I forgot to try cross-compiling for ARM in debug mode as well. D'oh. The 64-bit ...
12 years, 3 months ago (2008-09-11 17:57:28 UTC) #1
iposva
12 years, 3 months ago (2008-09-12 03:16:34 UTC) #2
On 2008/09/11 17:57:28, plesner wrote:
> I forgot to try cross-compiling for ARM in debug mode as well.  D'oh.
> 
> The 64-bit linux issues are actually unrelated -- they are caused by Søren's
> changes to the build system.

LGTM

Actually I am going to submit them because I need these pending fixes to make
forward progress.

Powered by Google App Engine
This is Rietveld 408576698