Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1943993008: Revert of Enable hermetic builds for FYI mac tot builders only. (Closed)

Created:
4 years, 7 months ago by justincohen
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Enable hermetic builds for FYI mac builders. This leaves hermetic enabled for: Chromium Mac 10.10 MacViews Chromium Mac 10.11 Chromium Mac 10.9 Goma Canary Chromium Mac 10.9 Goma Canary (clobber) Chromium Mac 10.9 Goma Canary (dbg) Chromium Mac 10.9 Goma Canary (dbg) (clobber) Mac OpenSSL Print Preview Mac But disables them for: ClangToTMac ClangToTMacASan ClangToTMacASan tester ClangToTMac dbg ClangToTMac tester Original issue's description: > Reland of Enable hermetic builds for FYI mac builders. (patchset #1 id:1 of https://codereview.chromium.org/1946023004/ ) > > Reason for revert: > Try this CL again now that the sudoers change has been applied via puppet. > > Original issue's description: > > Revert of Enable hermetic builds for FYI mac builders. (patchset #2 id:20001 of https://codereview.chromium.org/1942383002/ ) > > > > Reason for revert: > > This broke a bunch of FYI bots. > > > > Original issue's description: > > > Enable hermetic builds for FYI mac builders. > > > > > > BUG=474373 > > > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300441 > > > > TBR=phajdan.jr@chromium.org,dpranke@chromium.org,erikchen@chromium.org,shrike@chromium.org,smut@google.com > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=474373 > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300448 > > TBR=phajdan.jr@chromium.org,dpranke@chromium.org,erikchen@chromium.org,shrike@chromium.org,smut@google.com > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=474373 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300469 TBR=phajdan.jr@chromium.org,dpranke@chromium.org,erikchen@chromium.org,shrike@chromium.org,smut@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474373 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300477

Patch Set 1 #

Patch Set 2 : Revert totclang only #

Messages

Total messages: 10 (5 generated)
justincohen
Created Revert of Enable hermetic builds for FYI mac builders.
4 years, 7 months ago (2016-05-06 16:21:25 UTC) #1
Paweł Hajdan Jr.
LGTM
4 years, 7 months ago (2016-05-06 16:22:35 UTC) #2
smut
lgtm new patchset
4 years, 7 months ago (2016-05-06 22:11:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943993008/290001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943993008/290001
4 years, 7 months ago (2016-05-06 22:11:27 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 22:11:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:290001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300477

Powered by Google App Engine
This is Rietveld 408576698