chrome/browser/download/download_danger_prompt.cc - Issue 1943993006: Create test fixture for SafeBrowsingService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_danger_prompt.cc

Issue 1943993006: Create test fixture for SafeBrowsingService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_danger_prompt.cc

diff --git a/chrome/browser/download/download_danger_prompt.cc b/chrome/browser/download/download_danger_prompt.cc

index f5b2e8f4b4293a1e97bcbbe635e208337165ac37..ec90d5c3eedaa707294e2c1cfcb722d35a96475e 100644

--- a/chrome/browser/download/download_danger_prompt.cc

+++ b/chrome/browser/download/download_danger_prompt.cc

@@ -334,8 +334,8 @@ void DownloadDangerPrompt::SendSafeBrowsingDownloadRecoveryReport(

case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST:

report.set_download_verdict(ClientDownloadResponse::DANGEROUS_HOST);

break;

- default:

- break;

+ default: // Don't send report for any other danger types.

Nathan Parker 2016/05/07 00:05:32 Does this change the behaviour? Isn't test code..

Jialiu Lin 2016/05/12 21:53:58 Oops, added a test in download_danger_prompt_brows

+ return;

}

report.set_url(download.GetURL().spec());

report.set_did_proceed(did_proceed);