Create test fixture for SafeBrowsingService

chrome/browser/download/download_danger_prompt.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_danger_prompt.h"
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/strings/stringprintf.h"
@@ skipping 240 matching lines @@
 }
 
 void DownloadDangerPromptImpl::RunDone(Action action) {
   // Invoking the callback can cause the download item state to change or cause
   // the constrained window to close, and |callback| refers to a member
   // variable.
   OnDone done = done_;
   done_.Reset();
   if (download_ != NULL) {
     const bool accept = action == DownloadDangerPrompt::ACCEPT;
-    RecordDownloadDangerPrompt(accept, *download_);
-    if (!download_->GetURL().is_empty() &&
-        !download_->GetBrowserContext()->IsOffTheRecord()) {
-      SendSafeBrowsingDownloadRecoveryReport(accept, *download_);
+    if (download_->IsDangerous() && !download_->IsDone()) {
+      RecordDownloadDangerPrompt(accept, *download_);
+      if (!download_->GetURL().is_empty() &&
+          !download_->GetBrowserContext()->IsOffTheRecord()) {
+        SendSafeBrowsingDownloadRecoveryReport(accept, *download_);
+      }
     }
     download_->RemoveObserver(this);
     download_ = NULL;
   }
   if (!done.is_null())
     done.Run(action);
 }
 
 // Converts DownloadDangerType into their corresponding string.
 const char* GetDangerTypeString(
@@ skipping 52 matching lines @@
       break;
     case content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT:
       report.set_download_verdict(ClientDownloadResponse::UNCOMMON);
       break;
     case content::DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED:
       report.set_download_verdict(ClientDownloadResponse::POTENTIALLY_UNWANTED);
       break;
     case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST:
       report.set_download_verdict(ClientDownloadResponse::DANGEROUS_HOST);
       break;
-    default:
-      break;
+    default:  // Don't send report for any other danger types.
+      return;
   }
   report.set_url(download.GetURL().spec());
   report.set_did_proceed(did_proceed);
 
   std::string serialized_report;
   if (report.SerializeToString(&serialized_report))
     sb_service->SendSerializedDownloadReport(serialized_report);
   else
     DLOG(ERROR) << "Unable to serialize the threat report.";
 }
 
 void DownloadDangerPrompt::RecordDownloadDangerPrompt(
     bool did_proceed,
     const content::DownloadItem& download) {
   int dangerous_file_type =
       GetSBClientDownloadExtensionValueForUMA(download.GetTargetFilePath());
   content::DownloadDangerType danger_type = download.GetDangerType();
 
   UMA_HISTOGRAM_SPARSE_SLOWLY(
       base::StringPrintf("%s.%s.Shown", kDownloadDangerPromptPrefix,
                          GetDangerTypeString(danger_type)),
       dangerous_file_type);
   if (did_proceed) {
     UMA_HISTOGRAM_SPARSE_SLOWLY(
         base::StringPrintf("%s.%s.Proceed", kDownloadDangerPromptPrefix,
                            GetDangerTypeString(danger_type)),
         dangerous_file_type);
   }
 }