Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1943973002: Revert of Make GrStyle more sk_sp savy (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make GrStyle more sk_sp savy (patchset #1 id:1 of https://codereview.chromium.org/1947543002/ ) Reason for revert: Crashing Ubuntu/GCC bot (but not clang) Original issue's description: > Make GrStyle more sk_sp savy > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1947543002 > > Committed: https://skia.googlesource.com/skia/+/46db22f1cfc65a7a4f1de13d774718347362f60f TBR=robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/308febaebd7048041ecd3ef4487e893238119d08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/gpu/GrStyle.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrStyle.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bsalomon
Created Revert of Make GrStyle more sk_sp savy
4 years, 7 months ago (2016-05-03 17:11:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943973002/1
4 years, 7 months ago (2016-05-03 17:11:51 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 17:11:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/308febaebd7048041ecd3ef4487e893238119d08

Powered by Google App Engine
This is Rietveld 408576698