Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1943963004: Revert of (reland) Move permission.mojom from WebKit/public/platform/ to components/ (Closed)

Created:
4 years, 7 months ago by Mathieu
Modified:
4 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, johnme+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, nyquist+watch-blimp_chromium.org, haraken, dglazkov+blink, kmarshall+watch-blimp_chromium.org, ben+mojo_chromium.org, maniscalco+watch-blimp_chromium.org, mlamouri+watch-geolocation_chromium.org, mvanouwerkerk+watch_chromium.org, iclelland+watch_chromium.org, lcwu+watch_chromium.org, jam, chasej+watch_chromium.org, abarth-chromium, eme-reviews_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, halliwell+watch_chromium.org, blink-reviews, harkness+watch_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, toyoshim+midi_chromium.org, dkrahn+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, oshima+watch_chromium.org, Michael van Ouwerkerk, mlamouri+watch-permissions_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-api_chromium.org, Aaron Boodman, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), dtrainor+watch-blimp_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of (reland) Move permission.mojom from WebKit/public/platform/ to components/ (patchset #3 id:40001 of https://codereview.chromium.org/1942353002/ ) Reason for revert: Sorry, it's causing failures on many bots, reliably on Google Chrome OS bot: https://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=17561 Original issue's description: > (reland) Move permission.mojom from WebKit/public/platform/ to components/ > > This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix. > > Mojo permission interface is needed by other parts of Chromium, e.g. > media. > Hence move it to a more common place. > > BUG=604503 > TBR=mlamouri@chromium.org,dcheng@chromium.org > TEST=No functionality change. > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305 > Cr-Commit-Position: refs/heads/master@{#391441} TBR=jam@chromium.org,dcheng@chromium.org,mlamouri@chromium.org,xhwang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=604503 Committed: https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8 Cr-Commit-Position: refs/heads/master@{#391514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+415 lines, -514 lines) Patch
M android_webview/browser/aw_permission_manager.h View 3 chunks +8 lines, -9 lines 0 comments Download
M android_webview/browser/aw_permission_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/app/blimp_permission_manager.h View 2 chunks +7 lines, -7 lines 0 comments Download
M blimp/engine/app/blimp_permission_manager.cc View 4 chunks +12 lines, -14 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/notifications/notification_permission_context_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 6 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_interactive_uitest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/permissions/permission_manager.h View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/permissions/permission_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_uma_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_permission_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_permission_context.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chromecast/browser/cast_permission_manager.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chromecast/browser/cast_permission_manager.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M components/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M components/components.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D components/permissions.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D components/permissions/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D components/permissions/OWNERS View 1 chunk +0 lines, -15 lines 0 comments Download
D components/permissions/permission.mojom View 1 chunk +0 lines, -43 lines 0 comments Download
D components/permissions/permission_status.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
M content/DEPS View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/DEPS View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/background_sync/background_sync_manager_unittest.cc View 5 chunks +4 lines, -4 lines 0 comments Download
M content/browser/background_sync/background_sync_service_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.h View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/notifications/notification_message_filter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/notifications/notification_message_filter.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M content/browser/permissions/permission_service_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/permissions/permission_service_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/permissions/permission_service_impl.h View 4 chunks +21 lines, -22 lines 0 comments Download
M content/browser/permissions/permission_service_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/push_messaging/push_messaging_message_filter.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/notifications/notification_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/notifications/notification_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/permissions/permission_dispatcher.h View 4 chunks +11 lines, -12 lines 0 comments Download
M content/child/permissions/permission_dispatcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/platform_notification_messages.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/permission_manager.h View 5 chunks +6 lines, -9 lines 0 comments Download
M content/public/browser/platform_notification_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/common_param_traits_macros.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/geolocation_dispatcher.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/geolocation_dispatcher.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/media_permission_dispatcher.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/media_permission_dispatcher.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M content/renderer/media/midi_dispatcher.h View 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/media/midi_dispatcher.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M content/renderer/notification_permission_dispatcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/notification_permission_dispatcher.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_permission_manager.h View 3 chunks +10 lines, -10 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_permission_manager.cc View 9 chunks +17 lines, -19 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_push_messaging_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/browser/shell_permission_manager.h View 2 chunks +7 lines, -7 lines 0 comments Download
M content/shell/browser/shell_permission_manager.cc View 4 chunks +16 lines, -18 lines 0 comments Download
M content/shell/common/layout_test/layout_test_messages.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M content/test/mock_permission_manager.h View 2 chunks +10 lines, -11 lines 0 comments Download
M content/test/mock_permission_manager.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h View 2 chunks +3 lines, -5 lines 0 comments Download
A third_party/WebKit/public/platform/modules/permissions/permission.mojom View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/permissions/permission_status.mojom View 1 chunk +12 lines, -0 lines 0 comments Download
D third_party/WebKit/public/web/modules/notifications/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/modules/notifications/WebNotificationPermissionCallback.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mathieu
Created Revert of (reland) Move permission.mojom from WebKit/public/platform/ to components/
4 years, 7 months ago (2016-05-04 15:20:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943963004/1
4 years, 7 months ago (2016-05-04 15:20:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 15:22:30 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 15:23:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8
Cr-Commit-Position: refs/heads/master@{#391514}

Powered by Google App Engine
This is Rietveld 408576698