Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2020)

Unified Diff: android_webview/browser/test/rendering_test.h

Issue 1943963003: WIP Handle AwContents needing multiple live functors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from PS17 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/test/fake_window.cc ('k') | android_webview/browser/test/rendering_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/test/rendering_test.h
diff --git a/android_webview/browser/test/rendering_test.h b/android_webview/browser/test/rendering_test.h
index 8fa5501fb0517fdceb15f5267996afece20a295b..5b369d473b8d79adadf209dbe248e27077950836 100644
--- a/android_webview/browser/test/rendering_test.h
+++ b/android_webview/browser/test/rendering_test.h
@@ -38,7 +38,6 @@ struct ParentCompositorDrawConstraints;
class RenderingTest : public testing::Test,
public BrowserViewRendererClient,
- public RenderThreadManagerClient,
public WindowHooks {
public:
// BrowserViewRendererClient overrides.
@@ -54,13 +53,10 @@ class RenderingTest : public testing::Test,
void DidOverscroll(const gfx::Vector2d& overscroll_delta,
const gfx::Vector2dF& overscroll_velocity) override {}
- // RenderThreadManagerClient overrides.
- bool RequestInvokeGL(bool wait_for_completion) override;
- void DetachFunctorFromView() override;
-
// WindowHooks overrides.
void WillOnDraw() override;
void DidOnDraw(bool success) override {}
+ FakeFunctor* GetFunctor() override;
void WillSyncOnRT() override {}
void DidSyncOnRT() override {}
void WillProcessOnRT() override {}
@@ -83,14 +79,13 @@ class RenderingTest : public testing::Test,
void RunTest();
void InitializeCompositor();
- void Attach();
void EndTest();
std::unique_ptr<cc::CompositorFrame> ConstructEmptyFrame();
std::unique_ptr<cc::CompositorFrame> ConstructFrame(
cc::ResourceId resource_id);
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
std::unique_ptr<FakeWindow> window_;
- std::unique_ptr<RenderThreadManager> render_thread_manager_;
+ std::unique_ptr<FakeFunctor> functor_;
std::unique_ptr<BrowserViewRenderer> browser_view_renderer_;
std::unique_ptr<content::TestSynchronousCompositor> compositor_;
« no previous file with comments | « android_webview/browser/test/fake_window.cc ('k') | android_webview/browser/test/rendering_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698