Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2262)

Unified Diff: android_webview/browser/test/rendering_test.h

Issue 1943963003: WIP Handle AwContents needing multiple live functors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Testing framework changes to support testing multiple RenderThreadManager instances. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/test/rendering_test.h
diff --git a/android_webview/browser/test/rendering_test.h b/android_webview/browser/test/rendering_test.h
index 8fa5501fb0517fdceb15f5267996afece20a295b..e6626e0721efb9e6dfd552ba2198b4b077bf2573 100644
--- a/android_webview/browser/test/rendering_test.h
+++ b/android_webview/browser/test/rendering_test.h
@@ -38,7 +38,6 @@ struct ParentCompositorDrawConstraints;
class RenderingTest : public testing::Test,
public BrowserViewRendererClient,
- public RenderThreadManagerClient,
public WindowHooks {
public:
// BrowserViewRendererClient overrides.
@@ -54,10 +53,6 @@ class RenderingTest : public testing::Test,
void DidOverscroll(const gfx::Vector2d& overscroll_delta,
const gfx::Vector2dF& overscroll_velocity) override {}
- // RenderThreadManagerClient overrides.
- bool RequestInvokeGL(bool wait_for_completion) override;
- void DetachFunctorFromView() override;
-
// WindowHooks overrides.
void WillOnDraw() override;
void DidOnDraw(bool success) override {}
@@ -70,6 +65,9 @@ class RenderingTest : public testing::Test,
virtual void OnParentDrawConstraintsUpdated() {}
+ virtual RenderThreadManager* CreateRenderThreadManager(
boliu 2016/05/10 15:18:20 return unique_ptr to imply passing ownership
Tobias Sargeant 2016/05/13 13:23:57 Removed; don't need the factory any more.
+ RenderThreadManagerClient* client);
+
protected:
RenderingTest();
@@ -90,7 +88,7 @@ class RenderingTest : public testing::Test,
cc::ResourceId resource_id);
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
std::unique_ptr<FakeWindow> window_;
- std::unique_ptr<RenderThreadManager> render_thread_manager_;
+ std::unique_ptr<Functor> functor_;
std::unique_ptr<BrowserViewRenderer> browser_view_renderer_;
std::unique_ptr<content::TestSynchronousCompositor> compositor_;

Powered by Google App Engine
This is Rietveld 408576698