Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: android_webview/browser/browser_view_renderer_unittest.cc

Issue 1943963003: WIP Handle AwContents needing multiple live functors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: PS7 comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/browser_view_renderer_unittest.cc
diff --git a/android_webview/browser/browser_view_renderer_unittest.cc b/android_webview/browser/browser_view_renderer_unittest.cc
index 0eba0a82c17b8268e9e38db6ec8c1f22b9e7dbfa..0122c08d1990fee282604499c2281239d9dac892 100644
--- a/android_webview/browser/browser_view_renderer_unittest.cc
+++ b/android_webview/browser/browser_view_renderer_unittest.cc
@@ -123,6 +123,9 @@ class TestAnimateInAndOutOfScreen : public RenderingTest {
ParentCompositorDrawConstraints constraints =
GetCompositorFrameConsumer()->GetParentDrawConstraintsOnUI();
switch (on_draw_count_) {
+ case 0u:
+ EXPECT_TRUE(DrawConstraintsEquals(constraints, initial_constraints_));
boliu 2016/05/05 21:40:32 iirc leaving this out was a deliberate choice, thi
Tobias Sargeant 2016/05/06 12:41:09 We can remove the EXPECT_TRUE, however this CL add
+ break;
case 1u:
EXPECT_TRUE(DrawConstraintsEquals(constraints, new_constraints_));
break;
@@ -334,6 +337,7 @@ class RenderThreadManagerDeletionTest : public ResourceRenderingTest {
void CheckResults() override {
OutputSurfaceResourceCountMap resource_counts;
+ browser_view_renderer_->SetCurrentCompositorFrameConsumer(nullptr);
render_thread_manager_.reset();
// Make sure resources for the last frame are returned.
EXPECT_EQ(expected_return_count_, GetReturnedResourceCounts());

Powered by Google App Engine
This is Rietveld 408576698