Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1943923002:
[Interpreter] Do not write Ignition dispatch counters to file by default. (Closed)
|
Created:
4 years, 7 months ago by Stefano Sanfilippo Modified:
4 years, 7 months ago CC:
v8-reviews_googlegroups.com, Michael Hablich Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Interpreter] Do not write Ignition dispatch counters to file by default.
Since Ignition dispatch counters have been made accessible from
JavaScript via getIgnitionDispatchCounters() in [1], writing
them to a file at the end of the execution does not seem the best
default anymore.
Following this commit, a file is written only if d8 is invoked
with --trace-ignition-dispatches-output-file.
[1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30
LOG=N
BUG=v8:4899
Committed: https://crrev.com/4b3953df59a4a78961b0902fb98007b40439dc6e
Cr-Commit-Position: refs/heads/master@{#36015}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix spelling. #Messages
Total messages: 30 (19 generated)
The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943923002/1
Description was changed from ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Ignition dispatch counters can be accessed in JavaScript via getIgnitionDispatchCounters() since [1]. After that change, saving the table to file does not seem the best default anymore. From this commit, the dispatch counters are saved to file only when d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ========== to ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Ignition dispatch counters can be accessed in JavaScript via getIgnitionDispatchCounters() since [1]. After that change, saving the counters to file does not seem the best default anymore. From this commit, the dispatch counters are written to file only when d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ==========
Description was changed from ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Ignition dispatch counters can be accessed in JavaScript via getIgnitionDispatchCounters() since [1]. After that change, saving the counters to file does not seem the best default anymore. From this commit, the dispatch counters are written to file only when d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ========== to ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Ignition dispatch counters can be accessed in JavaScript via getIgnitionDispatchCounters() since [1]. After that change, saving the counters to file does not seem the best default anymore. From this commit, the dispatch counters file is are written only when d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ==========
Description was changed from ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Ignition dispatch counters can be accessed in JavaScript via getIgnitionDispatchCounters() since [1]. After that change, saving the counters to file does not seem the best default anymore. From this commit, the dispatch counters file is are written only when d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ========== to ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Ignition dispatch counters can be accessed in JavaScript via getIgnitionDispatchCounters() since [1]. After that change, writing them to file does not seem the best default anymore. From this commit, the dispatch counters file is written only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Ignition dispatch counters can be accessed in JavaScript via getIgnitionDispatchCounters() since [1]. After that change, writing them to file does not seem the best default anymore. From this commit, the dispatch counters file is written only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ========== to ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Ignition dispatch counters can be accessed in JavaScript via getIgnitionDispatchCounters() since [1]. After that change, writing counters to file at the end of the execution does not seem the best default anymore. Following this commit, the dispatch counters are written to file only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ==========
Description was changed from ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Ignition dispatch counters can be accessed in JavaScript via getIgnitionDispatchCounters() since [1]. After that change, writing counters to file at the end of the execution does not seem the best default anymore. Following this commit, the dispatch counters are written to file only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ========== to ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() since [1], and writing counters to file at the end of the execution does not seem the best default anymore. Following this commit, the dispatch counters are written to file only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ==========
Description was changed from ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() since [1], and writing counters to file at the end of the execution does not seem the best default anymore. Following this commit, the dispatch counters are written to file only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ========== to ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() since [1], writing counters to file at the end of the execution does not seem the best default anymore. Following this commit, the dispatch counters are written to file only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ==========
Description was changed from ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() since [1], writing counters to file at the end of the execution does not seem the best default anymore. Following this commit, the dispatch counters are written to file only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ========== to ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() in [1], writing counters to file at the end of the execution does not seem the best default anymore. Following this commit, the dispatch counters are written to file only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ==========
ssanfilippo@chromium.org changed reviewers: + cbruni@chromium.org, rmcilroy@chromium.org
Here's another take on https://codereview.chromium.org/1949453002/, PTAL.
LGTM if Camillo is happy.
Forgot to publish comments: https://codereview.chromium.org/1943923002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1943923002/diff/1/src/flag-definitions.h#newc... src/flag-definitions.h:304: "written (by default, the table is not written to file)") /s/to file/to a file/
On 2016/05/03 at 15:56:26, rmcilroy wrote: > Forgot to publish comments: > > https://codereview.chromium.org/1943923002/diff/1/src/flag-definitions.h > File src/flag-definitions.h (right): > > https://codereview.chromium.org/1943923002/diff/1/src/flag-definitions.h#newc... > src/flag-definitions.h:304: "written (by default, the table is not written to file)") > /s/to file/to a file/ thanks :)
The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943923002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() in [1], writing counters to file at the end of the execution does not seem the best default anymore. Following this commit, the dispatch counters are written to file only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ========== to ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() in [1], writing counters to a file at the end of the execution does not seem the best default anymore. Following this commit, the dispatch counters are written only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ==========
Description was changed from ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() in [1], writing counters to a file at the end of the execution does not seem the best default anymore. Following this commit, the dispatch counters are written only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ========== to ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() in [1], writing them to a file at the end of the execution does not seem the best default anymore. Following this commit, the dispatch counters are written only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ==========
Description was changed from ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() in [1], writing them to a file at the end of the execution does not seem the best default anymore. Following this commit, the dispatch counters are written only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ========== to ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() in [1], writing them to a file at the end of the execution does not seem the best default anymore. Following this commit, a file is written only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ==========
The CQ bit was checked by ssanfilippo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/1943923002/#ps20001 (title: "Fix spelling.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943923002/20001
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() in [1], writing them to a file at the end of the execution does not seem the best default anymore. Following this commit, a file is written only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ========== to ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() in [1], writing them to a file at the end of the execution does not seem the best default anymore. Following this commit, a file is written only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() in [1], writing them to a file at the end of the execution does not seem the best default anymore. Following this commit, a file is written only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 ========== to ========== [Interpreter] Do not write Ignition dispatch counters to file by default. Since Ignition dispatch counters have been made accessible from JavaScript via getIgnitionDispatchCounters() in [1], writing them to a file at the end of the execution does not seem the best default anymore. Following this commit, a file is written only if d8 is invoked with --trace-ignition-dispatches-output-file. [1] https://crrev.com/905becd13b8696e126255decf130fdb9e1d9aa30 LOG=N BUG=v8:4899 Committed: https://crrev.com/4b3953df59a4a78961b0902fb98007b40439dc6e Cr-Commit-Position: refs/heads/master@{#36015} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4b3953df59a4a78961b0902fb98007b40439dc6e Cr-Commit-Position: refs/heads/master@{#36015} |
