Touch up the New Tab Page Snippets UI.

Touch up the New Tab Page Snippets UI.

- Make the spacing between Articles absolute and not scale according to dpi.
- Change the timestamp's font size to 12sp.

BUG=607804, 607805
Committed: https://crrev.com/fbb2a3e0b2d28f5e724161a1ac6f85f41c547812
Cr-Commit-Position: refs/heads/master@{#391267}

[PEConn, 2016-05-03 14:24:12]

peconn@chromium.org changed reviewers:
+ bauerb@chromium.org

[PEConn, 2016-05-03 14:24:13]

PTAL, the changes are fairly trivial...

[Bernhard Bauer, 2016-05-03 14:57:05]

LGTM, but before/after screenshots would be nice.

[PEConn, 2016-05-03 15:21:30]

The CQ bit was checked by peconn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 15:21:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943893002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943893002/1

[commit-bot: I haz the power, 2016-05-03 15:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 15:51:22]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[PEConn, 2016-05-03 16:10:44]

Screenshots are attached to the bugs.

[PEConn, 2016-05-03 16:10:49]

The CQ bit was checked by peconn@chromium.org

[PEConn, 2016-05-03 16:10:49]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1943893002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-03 16:11:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943893002/20001

[commit-bot: I haz the power, 2016-05-03 16:56:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-03 16:57:51]

Description was changed from

==========
Touch up the New Tab Page Snippets UI.

- Make the spacing between Articles absolute and not scale according to dpi.
- Change the timestamp's font size to 12sp.

BUG=607804,607805
==========

to

==========
Touch up the New Tab Page Snippets UI.

- Make the spacing between Articles absolute and not scale according to dpi.
- Change the timestamp's font size to 12sp.

BUG=607804,607805

Committed: https://crrev.com/fbb2a3e0b2d28f5e724161a1ac6f85f41c547812
Cr-Commit-Position: refs/heads/master@{#391267}
==========

[commit-bot: I haz the power, 2016-05-03 16:57:53]

Patchset 2 (id:??) landed as
https://crrev.com/fbb2a3e0b2d28f5e724161a1ac6f85f41c547812
Cr-Commit-Position: refs/heads/master@{#391267}

[mcwilliams, 2016-05-05 13:09:15]

mcwilliams@chromium.org changed reviewers:
+ mcwilliams@chromium.org

[mcwilliams, 2016-05-05 13:09:16]

https://codereview.chromium.org/1943893002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java
(right):

https://codereview.chromium.org/1943893002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java:15:
private static final int VERTICAL_SPACE = 1;
I did not see this change go through and I feel this change is incorrect.

[Bernhard Bauer, 2016-05-05 13:20:47]

https://codereview.chromium.org/1943893002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java
(right):

https://codereview.chromium.org/1943893002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java:15:
private static final int VERTICAL_SPACE = 1;
On 2016/05/05 13:09:16, mcwilliams wrote:
> I did not see this change go through and I feel this change is incorrect.

Can you elaborate?

[PEConn, 2016-05-05 13:22:25]

Could we move this discussion over to the bug?
https://bugs.chromium.org/p/chromium/issues/detail?id=607805