Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1943883002: [turbofan] Better test for for-in/continue OSR problem. (Closed)

Created:
4 years, 7 months ago by Jarin
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Better test for for-in/continue OSR problem. The problem is actually not related to try-catch, so here is a test without try-catch. BUG=chromium:607493 LOG=n Committed: https://crrev.com/caf460b2882e44b95abffb08945891ca1ba6cb53 Cr-Commit-Position: refs/heads/master@{#35985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M test/mjsunit/compiler/regress-607493.js View 1 chunk +26 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Jarin
Just a better regression test (one that does not rely on shipping try-catch). Could you ...
4 years, 7 months ago (2016-05-03 13:47:21 UTC) #4
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-03 13:51:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943883002/1
4 years, 7 months ago (2016-05-03 13:52:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 14:05:12 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 14:05:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/caf460b2882e44b95abffb08945891ca1ba6cb53
Cr-Commit-Position: refs/heads/master@{#35985}

Powered by Google App Engine
This is Rietveld 408576698