Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1943853003: [Autofill] Sort existing profiles by frecency before trying to merge. (Closed)

Created:
4 years, 7 months ago by sebsg
Modified:
4 years, 7 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sort existing profiles by frecency before matching for a similar profile. That way the "most useful" profiles will be checked first. BUG=608847 TEST=PersonalDataManagerTest Committed: https://crrev.com/a57a0b24cba8e3399731b8429af7cebd4d432619 Cr-Commit-Position: refs/heads/master@{#391361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -2 lines) Patch
M components/autofill/core/browser/personal_data_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +10 lines, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sebsg
Could you please take a look?
4 years, 7 months ago (2016-05-03 19:19:23 UTC) #6
Mathieu
lgtm
4 years, 7 months ago (2016-05-03 19:59:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943853003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943853003/60001
4 years, 7 months ago (2016-05-03 20:03:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 7 months ago (2016-05-03 21:28:36 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 21:30:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a57a0b24cba8e3399731b8429af7cebd4d432619
Cr-Commit-Position: refs/heads/master@{#391361}

Powered by Google App Engine
This is Rietveld 408576698