Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1943853002: Reland of Add support for device-change notifications to MediaStreamDispatcher (Closed)

Created:
4 years, 7 months ago by Guido Urdaneta
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, hta - Chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add support for device-change notifications to MediaStreamDispatcher (patchset #1 id:1 of https://codereview.chromium.org/1945603002/ ) Reason for revert: Will remove EXPECT_DEATH, which is problematic in a few supported platforms when there is more than one thread. Original issue's description: > Revert of Add support for device-change notifications to MediaStreamDispatcher (patchset #2 id:270001 of https://codereview.chromium.org/1943213002/ ) > > Reason for revert: > Still seems to break tests. See e.g. > > https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/20743/steps/content_unittests%20on%20Mac-10.9 > > Original issue's description: > > Reland of Add support for device-change notifications to MediaStreamDispatcher (patchset #1 id:1 of https://codereview.chromium.org/1939313003/ ) > > > > Reason for revert: > > This reland should fix the offending test. > > > > Original issue's description: > > > Revert of Add support for device-change notifications to MediaStreamDispatcher and MediaStreamDispatcherHost (patchset #6 id:100001 of https://codereview.chromium.org/1918173002/ ) > > > > > > Reason for revert: > > > This has caused content_browsertests to fail on multiple builders, e.g.: > > > > > > https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/23972 > > > https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/34086 > > > > > > Original issue's description: > > > > Add support for device-change notifications to MediaStreamDispatcher and MediaStreamDispatcherHost > > > > > > > > This is a step towards supporting the "devicechange" event in Blink. > > > > > > > > BUG=388648 > > > > > > > > Committed: https://crrev.com/ec334e1799ae25aaa1b0c66e25af641018a3a84a > > > > Cr-Commit-Position: refs/heads/master@{#391114} > > > > > > TBR=tommi@chromium.org,palmer@chromium.org,bbudge@chromium.org,hta@chromium.org,guidou@chromium.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=388648 > > > > > > Committed: https://crrev.com/2396227939dc83d23f2523a992b0e35da50d631e > > > Cr-Commit-Position: refs/heads/master@{#391141} > > > > TBR=tommi@chromium.org,palmer@chromium.org,bbudge@chromium.org,hta@chromium.org,dpranke@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=388648 > > > > Committed: https://crrev.com/cb53c53e9816623ac51e9b151815897ba2a30b22 > > Cr-Commit-Position: refs/heads/master@{#391192} > > TBR=tommi@chromium.org,palmer@chromium.org,bbudge@chromium.org,hta@chromium.org,dpranke@chromium.org,perkj@chromium.org,guidou@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=388648 > > Committed: https://crrev.com/ce93576c57265e1d407fa122a98743e339686256 > Cr-Commit-Position: refs/heads/master@{#391202} TBR=tommi@chromium.org,palmer@chromium.org,bbudge@chromium.org,hta@chromium.org,dpranke@chromium.org,perkj@chromium.org,henrika@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=388648 Committed: https://crrev.com/da330facfb86b325030fef9bc7cf4f85930b6d16 Cr-Commit-Position: refs/heads/master@{#391216}

Patch Set 1 #

Patch Set 2 : remove EXPECT_DEATH from unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -21 lines) Patch
M content/browser/renderer_host/media/media_stream_dispatcher_host.h View 1 3 chunks +28 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 1 7 chunks +84 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 8 chunks +47 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/media/media_stream_messages.h View 1 2 chunks +12 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.h View 1 4 chunks +16 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 1 4 chunks +49 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_dispatcher_eventhandler.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher_unittest.cc View 1 5 chunks +24 lines, -2 lines 0 comments Download
M content/renderer/media/user_media_client_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_media_device_manager.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/pepper_media_device_manager.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Guido Urdaneta
Created Reland of Add support for device-change notifications to MediaStreamDispatcher
4 years, 7 months ago (2016-05-03 13:07:42 UTC) #1
Guido Urdaneta
On 2016/05/03 13:07:42, Guido Urdaneta wrote: > Created Reland of Add support for device-change notifications ...
4 years, 7 months ago (2016-05-03 13:15:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943853002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943853002/180001
4 years, 7 months ago (2016-05-03 13:17:09 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:180001)
4 years, 7 months ago (2016-05-03 13:17:47 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 13:18:51 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da330facfb86b325030fef9bc7cf4f85930b6d16
Cr-Commit-Position: refs/heads/master@{#391216}

Powered by Google App Engine
This is Rietveld 408576698