third_party/WebKit/Source/core/dom/ElementRareData.cpp - Issue 1943803002: Move PseudoElements storage to their own object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ElementRareData.cpp

Issue 1943803002: Move PseudoElements storage to their own object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ElementRareData.cpp

diff --git a/third_party/WebKit/Source/core/dom/ElementRareData.cpp b/third_party/WebKit/Source/core/dom/ElementRareData.cpp

index d0f695936288b82482d29216f89a95583022628a..dd2bd6942d4b1d6e0ad1225134f29ca50ecef4e8 100644

--- a/third_party/WebKit/Source/core/dom/ElementRareData.cpp

+++ b/third_party/WebKit/Source/core/dom/ElementRareData.cpp

@@ -40,7 +40,7 @@ struct SameSizeAsElementRareData : NodeRareData {

short indices[1];

LayoutSize sizeForResizing;

IntSize scrollOffset;

- void* pointers[13];

+ void* pointers[10];

Member<void*> persistentMember[3];

};

@@ -76,11 +76,8 @@ DEFINE_TRACE_AFTER_DISPATCH(ElementRareData)

visitor->trace(m_elementAnimations);

visitor->trace(m_cssomWrapper);

visitor->trace(m_cssomMapWrapper);

+ visitor->trace(m_pseudoElementData);

visitor->trace(m_customElementDefinition);

- visitor->trace(m_generatedBefore);

- visitor->trace(m_generatedAfter);

- visitor->trace(m_generatedFirstLetter);

- visitor->trace(m_backdrop);

visitor->trace(m_intersectionObserverData);

NodeRareData::traceAfterDispatch(visitor);

}