Move PseudoElements storage to their own object.

third_party/WebKit/Source/core/dom/PseudoElementData.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PseudoElementData_h
+#define PseudoElementData_h
+
+#include "platform/heap/Handle.h"
+
+namespace blink {
+
+class PseudoElementData : public GarbageCollectedFinalized<PseudoElementData> {

[sof, 2016/05/06 05:22:15]

You can use GarbageCollected<> now + make the class 'final'.

[ramya.v, 2016/05/06 06:16:06]

Done.

+    WTF_MAKE_NONCOPYABLE(PseudoElementData);
+public:
+    static PseudoElementData* create();
+    void setPseudoElement(PseudoId, PseudoElement*);
+    PseudoElement* pseudoElement(PseudoId) const;
+    bool hasPseudoElements() const;
+    DEFINE_INLINE_TRACE()
+    {
+        visitor->trace(m_generatedBefore);
+        visitor->trace(m_generatedAfter);
+        visitor->trace(m_generatedFirstLetter);
+        visitor->trace(m_backdrop);
+    }
+private:
+    PseudoElementData() = default;
+    Member<PseudoElement> m_generatedBefore;
+    Member<PseudoElement> m_generatedAfter;
+    Member<PseudoElement> m_generatedFirstLetter;
+    Member<PseudoElement> m_backdrop;
+};
+
+inline PseudoElementData* PseudoElementData::create()
+{
+    return new PseudoElementData();
+}
+
+inline bool PseudoElementData::hasPseudoElements() const
+{
+    return m_generatedBefore || m_generatedAfter || m_backdrop || m_generatedFirstLetter;
+}
+
+inline void PseudoElementData::setPseudoElement(PseudoId pseudoId, PseudoElement* element)
+{
+    switch (pseudoId) {
+    case PseudoIdBefore:
+        if (m_generatedBefore)
+            m_generatedBefore->dispose();
+        m_generatedBefore = element;
+        break;
+    case PseudoIdAfter:
+        if (m_generatedAfter)
+            m_generatedAfter->dispose();
+        m_generatedAfter = element;
+        break;
+    case PseudoIdBackdrop:
+        if (m_backdrop)
+            m_backdrop->dispose();
+        m_backdrop = element;
+        break;
+    case PseudoIdFirstLetter:
+        if (m_generatedFirstLetter)
+            m_generatedFirstLetter->dispose();
+        m_generatedFirstLetter = element;
+        break;
+    default:
+        ASSERT_NOT_REACHED();
+    }
+}
+
+inline PseudoElement* PseudoElementData::pseudoElement(PseudoId pseudoId) const
+{
+    switch (pseudoId) {
+    case PseudoIdBefore:
+        return m_generatedBefore.get();

[sof, 2016/05/06 05:22:15]

The uses of get() are redundant, let's remove them while here.

[ramya.v, 2016/05/06 06:16:06]

Done.

+    case PseudoIdAfter:
+        return m_generatedAfter.get();
+    case PseudoIdBackdrop:
+        return m_backdrop.get();
+    case PseudoIdFirstLetter:
+        return m_generatedFirstLetter.get();
+    default:
+        return nullptr;
+    }
+}
+
+} // namespace blink
+
+#endif

[sof, 2016/05/06 05:22:15]

// PseudoElementData_h

[ramya.v, 2016/05/06 06:16:06]

Done.