Move PseudoElements storage to their own object.

third_party/WebKit/Source/core/dom/PseudoElement.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Neither the name of Google Inc. nor the names of its
@@ skipping 12 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef PseudoElement_h
 #define PseudoElement_h
 
 #include "core/CoreExport.h"
 #include "core/dom/Element.h"
 #include "core/style/ComputedStyle.h"
+#include "platform/heap/Handle.h"
 
 namespace blink {
 
 class CORE_EXPORT PseudoElement : public Element {
 public:
     static PseudoElement* create(Element* parent, PseudoId);
 
     PassRefPtr<ComputedStyle> customStyleForLayoutObject() override;
     void attach(const AttachContext& = AttachContext()) override;
     bool layoutObjectIsNeeded(const ComputedStyle&) override;
@@ skipping 10 matching lines @@
 
 protected:
     PseudoElement(Element*, PseudoId);
 
 private:
     void didRecalcStyle(StyleRecalcChange) override;
 
     PseudoId m_pseudoId;
 };
 
+class PseudoElementData : public GarbageCollectedFinalized<PseudoElementData> {

[Timothy Loh, 2016/05/05 06:39:32]

This should be in a separate file.

[ramya.v, 2016/05/05 08:57:09]

Done.

+    WTF_MAKE_NONCOPYABLE(PseudoElementData);
+public:
+    static PseudoElementData* create();
+    ~PseudoElementData();
+    void setPseudoElement(PseudoId, PseudoElement*);
+    PseudoElement* pseudoElement(PseudoId) const;
+    bool hasPseudoElements() const;
+    void clearPseudoElements();
+    DEFINE_INLINE_TRACE()
+    {
+        visitor->trace(m_generatedBefore);
+        visitor->trace(m_generatedAfter);
+        visitor->trace(m_generatedFirstLetter);
+        visitor->trace(m_backdrop);
+    }
+private:
+    PseudoElementData();

[Timothy Loh, 2016/05/05 06:39:33]

You could write "PseudoElementData() = default;" instead of explicitly defining
it.

[ramya.v, 2016/05/05 08:57:09]

Done.

+    Member<PseudoElement> m_generatedBefore;
+    Member<PseudoElement> m_generatedAfter;
+    Member<PseudoElement> m_generatedFirstLetter;
+    Member<PseudoElement> m_backdrop;
+};
+
+inline PseudoElementData* PseudoElementData::create()
+{
+    return new PseudoElementData();
+}
+
+inline PseudoElementData::PseudoElementData()
+{
+}
+
+inline PseudoElementData::~PseudoElementData()
+{
+    DCHECK(!m_generatedBefore);
+    DCHECK(!m_generatedAfter);
+    DCHECK(!m_generatedFirstLetter);
+    DCHECK(!m_backdrop);
+}
+
+inline bool PseudoElementData::hasPseudoElements() const
+{
+    return m_generatedBefore || m_generatedAfter || m_backdrop || m_generatedFirstLetter;
+}
+
+inline void PseudoElementData::clearPseudoElements()
+{
+    setPseudoElement(PseudoIdBefore, nullptr);
+    setPseudoElement(PseudoIdAfter, nullptr);
+    setPseudoElement(PseudoIdBackdrop, nullptr);
+    setPseudoElement(PseudoIdFirstLetter, nullptr);
+}
+
+inline void PseudoElementData::setPseudoElement(PseudoId pseudoId, PseudoElement* element)
+{
+    switch (pseudoId) {
+    case PseudoIdBefore:
+        if (m_generatedBefore)
+            m_generatedBefore->dispose();
+        m_generatedBefore = element;
+        break;
+    case PseudoIdAfter:
+        if (m_generatedAfter)
+            m_generatedAfter->dispose();
+        m_generatedAfter = element;
+        break;
+    case PseudoIdBackdrop:
+        if (m_backdrop)
+            m_backdrop->dispose();
+        m_backdrop = element;
+        break;
+    case PseudoIdFirstLetter:
+        if (m_generatedFirstLetter)
+            m_generatedFirstLetter->dispose();
+        m_generatedFirstLetter = element;
+        break;
+    default:
+        ASSERT_NOT_REACHED();
+    }
+}
+
+inline PseudoElement* PseudoElementData::pseudoElement(PseudoId pseudoId) const
+{
+    switch (pseudoId) {
+    case PseudoIdBefore:
+        return m_generatedBefore.get();
+    case PseudoIdAfter:
+        return m_generatedAfter.get();
+    case PseudoIdBackdrop:
+        return m_backdrop.get();
+    case PseudoIdFirstLetter:
+        return m_generatedFirstLetter.get();
+    default:
+        return 0;

[Timothy Loh, 2016/05/05 06:39:33]

nullptr

[ramya.v, 2016/05/05 08:57:09]

Done.

+    }
+}
+
 const QualifiedName& pseudoElementTagName();
 
 inline bool pseudoElementLayoutObjectIsNeeded(const ComputedStyle* style)
 {
     if (!style)
         return false;
     if (style->display() == NONE)
         return false;
     if (style->styleType() == PseudoIdFirstLetter || style->styleType() == PseudoIdBackdrop)
         return true;
     return style->contentData();
 }
 
 DEFINE_ELEMENT_TYPE_CASTS(PseudoElement, isPseudoElement());
 
 } // namespace blink
 
 #endif