components/ntp_snippets/ntp_snippets_fetcher.h - Issue 1943783002: [NTP Snippets] Add unit tests for NTPSnippetsFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_fetcher.h

Issue 1943783002: [NTP Snippets] Add unit tests for NTPSnippetsFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Introduce FailingFakeURLFetcherFactory to avoid null pointers. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/BUILD.gn ('k') | components/ntp_snippets/ntp_snippets_fetcher.cc » ('j') | components/ntp_snippets/ntp_snippets_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippets_fetcher.h

diff --git a/components/ntp_snippets/ntp_snippets_fetcher.h b/components/ntp_snippets/ntp_snippets_fetcher.h

index 65e526a801d36380b8a825b926b5cd97c9612ed1..70acd32f887cc96499988b8ccaa8d3c42753a82c 100644

--- a/components/ntp_snippets/ntp_snippets_fetcher.h

+++ b/components/ntp_snippets/ntp_snippets_fetcher.h

@@ -42,6 +42,10 @@ class NTPSnippetsFetcher : public net::URLFetcherDelegate {

// Fetches snippets from the server. |hosts| can be used to restrict the

// results to a set of hosts, e.g. "www.google.com". If it is empty, no

// restrictions are applied.

+ //

+ // If an ongoing fetch exists, it will be cancelled and a new one started,

+ // without triggering additional callbacks (i.e. not noticeable by

+ // subscribers).

void FetchSnippets(const std::set<std::string>& hosts, int count);

private:

« no previous file with comments | « components/ntp_snippets/BUILD.gn ('k') | components/ntp_snippets/ntp_snippets_fetcher.cc » ('j') | components/ntp_snippets/ntp_snippets_fetcher.cc » ('J')