Add v8::Object::GetOwnPropertyNames(context, filter) method

Add v8::Object::GetOwnPropertyNames(context, filter) method

This method provides ability to get all properties of the object with passed filter in addition to existing GetOwnPropertyNames(context) method that returns only enumerable properties.

BUG=v8:3861, chromium:581495
R=yangguo@chromium.org
LOG=Y

Committed: https://crrev.com/f0d27360a6e574eddcad5dca8ceba899c2fa0b3c
Cr-Commit-Position: refs/heads/master@{#36031}

[kozy, 2016-05-03 07:21:35]

In DevTools we need a method that provides all own property names for object for
implementing completions.
There is one API for this purpose is exposed in ObjectMirror but we can use this
API only from DebuggerScript when debugger is enabled but in case of completions
we need this API all the time.
I've added new API method with custom filter.
Please take a look.
Example of usage on DeVTools side: https://codereview.chromium.org/1942073002/

[kozy, 2016-05-03 07:21:50]

Yang, please take a look.

[Yang, 2016-05-03 13:50:20]

yangguo@chromium.org changed reviewers:
+ jochen@chromium.org

[Yang, 2016-05-03 13:50:21]

Jochen, please take a look.

https://codereview.chromium.org/1943773002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1943773002/diff/1/include/v8.h#newcode2659
include/v8.h:2659: ONLY_WRITABLE = 1,
"ONLY" is a bit misleading. When you use 3 as filter, it's neither only writable
nor only enumerable, but both.

Can we call them "INCLUDE_WRITABLE", etc.?

https://codereview.chromium.org/1943773002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1943773002/diff/1/src/api.cc#newcode3920
src/api.cc:3920: static_cast<i::PropertyFilter>(filter))
Please add static checks to property-details.h that the exposed enum values are
equal to the corresponding internal enum values.

[Yang, 2016-05-03 13:51:05]

On 2016/05/03 13:50:21, Yang wrote:
> Jochen, please take a look.
> 
> https://codereview.chromium.org/1943773002/diff/1/include/v8.h
> File include/v8.h (right):
> 
> https://codereview.chromium.org/1943773002/diff/1/include/v8.h#newcode2659
> include/v8.h:2659: ONLY_WRITABLE = 1,
> "ONLY" is a bit misleading. When you use 3 as filter, it's neither only
writable
> nor only enumerable, but both.
> 
> Can we call them "INCLUDE_WRITABLE", etc.?

Never mind this comment. They simply reflect what the internal enums are named.

> 
> https://codereview.chromium.org/1943773002/diff/1/src/api.cc
> File src/api.cc (right):
> 
> https://codereview.chromium.org/1943773002/diff/1/src/api.cc#newcode3920
> src/api.cc:3920: static_cast<i::PropertyFilter>(filter))
> Please add static checks to property-details.h that the exposed enum values
are
> equal to the corresponding internal enum values.

[jochen (gone - plz use gerrit), 2016-05-03 14:44:39]

https://codereview.chromium.org/1943773002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1943773002/diff/1/include/v8.h#newcode2659
include/v8.h:2659: ONLY_WRITABLE = 1,
On 2016/05/03 at 13:50:20, Yang wrote:
> "ONLY" is a bit misleading. When you use 3 as filter, it's neither only
writable nor only enumerable, but both.
> 
> Can we call them "INCLUDE_WRITABLE", etc.?

would be nice to have a comment that says that this is a bit mask, etc..

[kozy, 2016-05-03 17:22:32]

Description was changed from

==========
Add v8::Object::GetOwnPropertyNames(context, filter) method

This method provides ability to get all properties of the object with passed
filter in addition to existing GetOwnPropertyNames(context) method that returns
only enumerable properties.

BUG=3861,chromium:581495
R=yangguo@chromium.org
LOG=Y
==========

to

==========
Add v8::Object::GetOwnPropertyNames(context, filter) method

This method provides ability to get all properties of the object with passed
filter in addition to existing GetOwnPropertyNames(context) method that returns
only enumerable properties.

BUG=v8:3861,chromium:581495
R=yangguo@chromium.org
LOG=Y
==========

[kozy, 2016-05-03 17:37:46]

All done. Please take a look.

https://codereview.chromium.org/1943773002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1943773002/diff/1/include/v8.h#newcode2659
include/v8.h:2659: ONLY_WRITABLE = 1,
On 2016/05/03 14:44:39, jochen wrote:
> On 2016/05/03 at 13:50:20, Yang wrote:
> > "ONLY" is a bit misleading. When you use 3 as filter, it's neither only
> writable nor only enumerable, but both.
> > 
> > Can we call them "INCLUDE_WRITABLE", etc.?
> 
> would be nice to have a comment that says that this is a bit mask, etc..

Done.

https://codereview.chromium.org/1943773002/diff/1/include/v8.h#newcode2659
include/v8.h:2659: ONLY_WRITABLE = 1,
On 2016/05/03 13:50:20, Yang wrote:
> "ONLY" is a bit misleading. When you use 3 as filter, it's neither only
writable
> nor only enumerable, but both.
> 
> Can we call them "INCLUDE_WRITABLE", etc.?

Acknowledged.

https://codereview.chromium.org/1943773002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1943773002/diff/1/src/api.cc#newcode3920
src/api.cc:3920: static_cast<i::PropertyFilter>(filter))
On 2016/05/03 13:50:20, Yang wrote:
> Please add static checks to property-details.h that the exposed enum values
are
> equal to the corresponding internal enum values.

Done.

[jochen (gone - plz use gerrit), 2016-05-04 10:52:35]

api lgtm

[jochen (gone - plz use gerrit), 2016-05-04 10:52:49]

jochen@chromium.org changed reviewers:
+ cbruni@chromium.org

[jochen (gone - plz use gerrit), 2016-05-04 10:52:49]

+cbruni fyi

[Yang, 2016-05-04 10:58:54]

On 2016/05/04 10:52:49, jochen wrote:
> +cbruni fyi

lgtm

[kozy, 2016-05-04 15:10:26]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-05-04 15:10:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943773002/20001

[commit-bot: I haz the power, 2016-05-04 15:16:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 15:16:08]

Try jobs failed on following builders:
  v8_win64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/6826)
  v8_win_compile_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/1...)

[kozy, 2016-05-04 15:38:40]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-05-04 15:38:40]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1943773002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-04 15:38:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943773002/40001

[commit-bot: I haz the power, 2016-05-04 16:15:17]

Description was changed from

==========
Add v8::Object::GetOwnPropertyNames(context, filter) method

This method provides ability to get all properties of the object with passed
filter in addition to existing GetOwnPropertyNames(context) method that returns
only enumerable properties.

BUG=v8:3861,chromium:581495
R=yangguo@chromium.org
LOG=Y
==========

to

==========
Add v8::Object::GetOwnPropertyNames(context, filter) method

This method provides ability to get all properties of the object with passed
filter in addition to existing GetOwnPropertyNames(context) method that returns
only enumerable properties.

BUG=v8:3861,chromium:581495
R=yangguo@chromium.org
LOG=Y
==========

[commit-bot: I haz the power, 2016-05-04 16:15:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-04 16:15:40]

Description was changed from

==========
Add v8::Object::GetOwnPropertyNames(context, filter) method

This method provides ability to get all properties of the object with passed
filter in addition to existing GetOwnPropertyNames(context) method that returns
only enumerable properties.

BUG=v8:3861,chromium:581495
R=yangguo@chromium.org
LOG=Y
==========

to

==========
Add v8::Object::GetOwnPropertyNames(context, filter) method

This method provides ability to get all properties of the object with passed
filter in addition to existing GetOwnPropertyNames(context) method that returns
only enumerable properties.

BUG=v8:3861,chromium:581495
R=yangguo@chromium.org
LOG=Y

Committed: https://crrev.com/f0d27360a6e574eddcad5dca8ceba899c2fa0b3c
Cr-Commit-Position: refs/heads/master@{#36031}
==========

[commit-bot: I haz the power, 2016-05-04 16:15:41]

Patchset 3 (id:??) landed as
https://crrev.com/f0d27360a6e574eddcad5dca8ceba899c2fa0b3c
Cr-Commit-Position: refs/heads/master@{#36031}