Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1943743003: Revert of [turbofan] Restore basic write barrier elimination. (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Restore basic write barrier elimination. (patchset #2 id:20001 of https://codereview.chromium.org/1938993002/ ) Reason for revert: Breaks WBs that should be there ;) https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305 Will open repro bug asap. Original issue's description: > [turbofan] Restore basic write barrier elimination. > > Restore the basic write barrier elimination that we used to run as part > of the simplified lowering phase (in ChangeLowering actually) before, by > moving the write barrier computation to SimplifiedLowering where we can > still look at types and consider the heap/isolate, and just update the > WriteBarrierKind in the FieldAccess/ElementAccess that we later use when > lowering to a machine Load/Store. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel > R=mstarzinger@chromium.org > BUG=v8:4969, chromium:608636 > LOG=n > > Committed: https://crrev.com/7dcb6ad379fbacbc8bdc8e11a6e50d680ffa3f62 > Cr-Commit-Position: refs/heads/master@{#35969} TBR=mstarzinger@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4969, chromium:608636 Committed: https://crrev.com/a782e93c617e728cded5ad878de11137a67891b7 Cr-Commit-Position: refs/heads/master@{#35983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -377 lines) Patch
M src/compiler/access-builder.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 9 chunks +149 lines, -220 lines 0 comments Download
M src/compiler/change-lowering.cc View 4 chunks +45 lines, -6 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 5 chunks +0 lines, -87 lines 0 comments Download
M src/compiler/simplified-operator.h View 3 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/simplified-operator.cc View 6 chunks +2 lines, -18 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -27 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Lippautz
Created Revert of [turbofan] Restore basic write barrier elimination.
4 years, 7 months ago (2016-05-03 13:44:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943743003/1
4 years, 7 months ago (2016-05-03 13:44:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 13:45:01 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a782e93c617e728cded5ad878de11137a67891b7 Cr-Commit-Position: refs/heads/master@{#35983}
4 years, 7 months ago (2016-05-03 13:45:35 UTC) #6
Michael Lippautz
4 years, 7 months ago (2016-05-03 13:54:59 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1943323002/ by mlippautz@chromium.org.

The reason for reverting is: Jakob found the actual issue with the CL and is
going to land the fix after relanding the WB elimination..

Powered by Google App Engine
This is Rietveld 408576698