Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1943733003: [heap] Fix IterateBlackObject for fixed arrays in large object space (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix IterateBlackObject for fixed arrays in large object space BUG=chromium:598319 LOG=N Committed: https://crrev.com/d70d17613aeb05085c89bf727693aaa40907b130 Cr-Commit-Position: refs/heads/master@{#35996}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/heap/incremental-marking.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Hannes Payer (out of office)
lgtm
4 years, 7 months ago (2016-05-03 18:49:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943733003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943733003/20001
4 years, 7 months ago (2016-05-03 18:50:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/1098) v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-03 18:52:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943733003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943733003/40001
4 years, 7 months ago (2016-05-03 18:56:57 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/17120) v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-03 18:58:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943733003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943733003/60001
4 years, 7 months ago (2016-05-03 18:59:27 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 7 months ago (2016-05-03 19:56:11 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 19:58:12 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d70d17613aeb05085c89bf727693aaa40907b130
Cr-Commit-Position: refs/heads/master@{#35996}

Powered by Google App Engine
This is Rietveld 408576698