mojo/public/tools/bindings/generators/mojom_go_generator.py - Issue 1943643002: Go bindings: Change generated enum value constants to be typed as the enum type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_go_generator.py

Issue 1943643002: Go bindings: Change generated enum value constants to be typed as the enum type. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/tools/bindings/generators/mojom_go_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_go_generator.py b/mojo/public/tools/bindings/generators/mojom_go_generator.py

index e9ea33f18b5320f3e1d741db6b72e9164635f89b..385989d0cc48c308fdc73f9d7c678720227922ef 100644

--- a/mojo/public/tools/bindings/generators/mojom_go_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_go_generator.py

@@ -370,7 +370,7 @@ class Generator(generator.Generator):

all_structs.append(self._GetResponseStructFromMethod(method))

if (len(all_structs) > 0 or len(self.module.interfaces) > 0

- or len(self.module.unions) > 0):

+ or len(self.module.unions) > 0 or len(self.module.enums) > 0):

imports['fmt'] = 'fmt'

imports['mojo/public/go/bindings'] = 'bindings'

if len(self.module.interfaces) > 0:

« no previous file with comments | « mojo/public/tools/bindings/generators/go_templates/enum.tmpl ('k') | no next file » | no next file with comments »