Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1943563002: Updates for js_array (Closed)

Created:
4 years, 7 months ago by sra1
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updates for js_array. Copy over most js_array methods. Remove IterableMixinWorkaround. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/71fa4e9e9570e8b6c492bac2053db3de8202b91e

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+903 lines, -1228 lines) Patch
M lib/runtime/dart_sdk.js View 1 2 3 4 5 6 7 100 chunks +521 lines, -724 lines 0 comments Download
M tool/input_sdk/lib/collection/list.dart View 3 chunks +12 lines, -2 lines 0 comments Download
M tool/input_sdk/lib/internal/iterable.dart View 1 2 3 4 1 chunk +0 lines, -402 lines 0 comments Download
M tool/input_sdk/lib/internal/list.dart View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/private/js_array.dart View 1 2 3 4 5 6 9 chunks +340 lines, -78 lines 0 comments Download
M tool/input_sdk/private/js_helper.dart View 1 2 3 4 4 chunks +13 lines, -6 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 2 3 4 5 6 3 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
4 years, 7 months ago (2016-05-05 17:55:36 UTC) #3
vsm
lgtm
4 years, 7 months ago (2016-05-05 18:12:27 UTC) #4
sra1
4 years, 7 months ago (2016-05-05 18:35:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #8 (id:140001) manually as
71fa4e9e9570e8b6c492bac2053db3de8202b91e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698