Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1943493003: [DevTools] 20px default top inset gutter to avoid Ruler overlap in emulation mode (Closed)

Created:
4 years, 7 months ago by mmccoy
Modified:
4 years, 7 months ago
Reviewers:
dgozman, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] 20px default top inset gutter to avoid Ruler overlap in emulation mode BUG=607418 Committed: https://crrev.com/a2f94c99443b636abcd96ed8f1153dd6c2338de6 Cr-Commit-Position: refs/heads/master@{#391135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mmccoy
It seems this extra top margin/gutter got lost in the landing of device frames, PTAL ...
4 years, 7 months ago (2016-05-02 20:15:52 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-05-02 23:17:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943493003/1
4 years, 7 months ago (2016-05-02 23:58:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 01:05:16 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 01:07:31 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a2f94c99443b636abcd96ed8f1153dd6c2338de6
Cr-Commit-Position: refs/heads/master@{#391135}

Powered by Google App Engine
This is Rietveld 408576698