Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

Issue 1943433002: DevTools: properly update close icon in search field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js b/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js
index 6cc960fd292accdc9179b1ac35a2e3254565868e..96ca16938fa80b362127a4f896b14385997b92e4 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js
@@ -18,7 +18,8 @@ WebInspector.AdvancedSearchView = function()
this._searchPanelElement = this.contentElement.createChild("div", "search-drawer-header");
this._searchPanelElement.addEventListener("keydown", this._onKeyDown.bind(this), false);
- this._searchPanelElement.addEventListener("keyup", this._onKeyUp.bind(this), false);
+ this._searchPanelElement.addEventListener("keyup", this._textChanged.bind(this), false);
lushnikov 2016/05/02 18:43:41 why would you need a keyup listener here? input sh
luoe 2016/05/02 19:18:52 You're right!
+ this._searchPanelElement.addEventListener("input", this._textChanged.bind(this), false);
this._searchResultsElement = this.contentElement.createChild("div");
this._searchResultsElement.className = "search-results";
@@ -296,7 +297,7 @@ WebInspector.AdvancedSearchView.prototype = {
}
},
- _onKeyUp: function()
+ _textChanged: function()
{
if (this._search.value && this._search.value.length)
this._searchInputClearElement.hidden = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698