DevTools: properly update close icon in search field

third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  */
 WebInspector.AdvancedSearchView = function()
 {
     WebInspector.VBox.call(this, true);
     this.setMinimumSize(0, 40);
     this.registerRequiredCSS("sources/sourcesSearch.css");
 
     this._searchId = 0;
 
     this.contentElement.classList.add("search-view");
 
     this._searchPanelElement = this.contentElement.createChild("div", "search-drawer-header");
     this._searchPanelElement.addEventListener("keydown", this._onKeyDown.bind(this), false);
-    this._searchPanelElement.addEventListener("keyup", this._onKeyUp.bind(this), false);
+    this._searchPanelElement.addEventListener("keyup", this._textChanged.bind(this), false);

[lushnikov, 2016/05/02 18:43:41]

why would you need a keyup listener here? input should cover all the usecases,
shouldn't it?

[luoe, 2016/05/02 19:18:52]

You're right!

+    this._searchPanelElement.addEventListener("input", this._textChanged.bind(this), false);
 
     this._searchResultsElement = this.contentElement.createChild("div");
     this._searchResultsElement.className = "search-results";
 
     this._search = WebInspector.HistoryInput.create();
     this._searchPanelElement.appendChild(this._search);
     this._search.placeholder = WebInspector.UIString("Search all sources (use \"file:\" to filter by path)\u200e");
     this._search.setAttribute("type", "text");
     this._search.classList.add("search-config-search");
     this._search.setAttribute("results", "0");
@@ skipping 257 matching lines @@
      */
     _onKeyDown: function(event)
     {
         switch (event.keyCode) {
         case WebInspector.KeyboardShortcut.Keys.Enter.code:
             this._onAction();
             break;
         }
     },
 
-    _onKeyUp: function()
+    _textChanged: function()
     {
         if (this._search.value && this._search.value.length)
             this._searchInputClearElement.hidden = false;
         else
             this._searchInputClearElement.hidden = true;
     },
 
     _save: function()
     {
         this._advancedSearchConfig.set(this._buildSearchConfig().toPlainObject());
@@ skipping 140 matching lines @@
     performIndexing: function(progress) { },
 
     stopSearch: function() { },
 
     /**
      * @param {!WebInspector.ProjectSearchConfig} searchConfig
      * @return {!WebInspector.SearchResultsPane}
      */
     createSearchResultsPane: function(searchConfig) { }
 }