Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1943433002:
DevTools: properly update close icon in search field (Closed)
|
Created:
4 years, 7 months ago by luoe Modified:
4 years, 7 months ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: properly update close icon in search field
BUG=608252
Committed: https://crrev.com/8a0127a88b7b690147fc7035a59d3c1cdf667dd0
Cr-Commit-Position: refs/heads/master@{#391265}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address comments #Messages
Total messages: 20 (9 generated)
Description was changed from ========== DevTools: properly update close icon in search field BUG=608252 ========== to ========== DevTools: properly update close icon in search field BUG=608252 ==========
luoe@chromium.org changed reviewers: + lushnikov@chromium.org
https://codereview.chromium.org/1943433002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js (right): https://codereview.chromium.org/1943433002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js:21: this._searchPanelElement.addEventListener("keyup", this._textChanged.bind(this), false); why would you need a keyup listener here? input should cover all the usecases, shouldn't it?
Unnecessary keyup listener removed. https://codereview.chromium.org/1943433002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js (right): https://codereview.chromium.org/1943433002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js:21: this._searchPanelElement.addEventListener("keyup", this._textChanged.bind(this), false); On 2016/05/02 18:43:41, lushnikov wrote: > why would you need a keyup listener here? input should cover all the usecases, > shouldn't it? You're right!
The CQ bit was checked by lushnikov@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943433002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943433002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943433002/20001
Message was sent while issue was closed.
Description was changed from ========== DevTools: properly update close icon in search field BUG=608252 ========== to ========== DevTools: properly update close icon in search field BUG=608252 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: properly update close icon in search field BUG=608252 ========== to ========== DevTools: properly update close icon in search field BUG=608252 Committed: https://crrev.com/8a0127a88b7b690147fc7035a59d3c1cdf667dd0 Cr-Commit-Position: refs/heads/master@{#391265} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8a0127a88b7b690147fc7035a59d3c1cdf667dd0 Cr-Commit-Position: refs/heads/master@{#391265} |
