Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: src/heap/mark-compact.cc

Issue 1943423002: Updates incremental marking pass to collect object statistics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed an unnecessary class declaration. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/incremental-marking.cc ('k') | src/heap/object-stats.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.cc
diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc
index 89ca782c267b317fc64bcb27f4c9442bb6424a7d..ad9600bfea5e6445dfe3b85839339ecd6071f8f7 100644
--- a/src/heap/mark-compact.cc
+++ b/src/heap/mark-compact.cc
@@ -1297,7 +1297,7 @@ void MarkCompactMarkingVisitor::Initialize() {
table_.Register(kVisitJSRegExp, &VisitRegExpAndFlushCode);
if (FLAG_track_gc_object_stats) {
- ObjectStatsVisitor::Initialize(&table_);
+ MarkCompactObjectStatsVisitor::Initialize(&table_);
}
}
@@ -2208,6 +2208,10 @@ void MarkCompactCollector::MarkLiveObjects() {
} else {
// Abort any pending incremental activities e.g. incremental sweeping.
incremental_marking->Stop();
+ if (FLAG_track_gc_object_stats) {
Hannes Payer (out of office) 2016/05/11 15:43:56 I think it is cleaner to clear the object stats ri
mythria 2016/05/11 15:52:26 They are already cleared after printing trace info
+ // Clear object stats collected during incremental marking.
+ heap()->object_stats_->ClearObjectStats();
+ }
if (marking_deque_.in_use()) {
marking_deque_.Uninitialize(true);
}
« no previous file with comments | « src/heap/incremental-marking.cc ('k') | src/heap/object-stats.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698