fix hairline clip

fix hairline clip

Don't remove inner clip if it's non-rectangular.
Add cubic hairline clip code to quad and conic cases.

R=reed@google.com
BUG=skia:5252
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1943403006

Committed: https://skia.googlesource.com/skia/+/4cba202b7162fb5f364235dd29f0bdbd53a8e33c

[caryclark, 2016-05-05 17:32:57]

Description was changed from

==========
fix hairline clip

Don't remove inner clip if it's non-rectangular.
Add cubic hairline clip code to quad and conic cases.

R=reed@google.com
BUG=skia:5252
==========

to

==========
fix hairline clip

Don't remove inner clip if it's non-rectangular.
Add cubic hairline clip code to quad and conic cases.

R=reed@google.com
BUG=skia:5252
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[caryclark, 2016-05-05 17:33:30]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 17:33:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943403006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943403006/1

[commit-bot: I haz the power, 2016-05-05 17:35:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 17:35:25]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[caryclark, 2016-05-09 13:09:33]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 13:09:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943403006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943403006/40001

[commit-bot: I haz the power, 2016-05-09 13:30:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 13:30:15]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-05-09 13:34:12]

PTAL

[reed1, 2016-05-11 19:47:50]

https://codereview.chromium.org/1943403006/diff/20001/src/core/SkScan_Hairlin...
File src/core/SkScan_Hairline.cpp (right):

https://codereview.chromium.org/1943403006/diff/20001/src/core/SkScan_Hairlin...
src/core/SkScan_Hairline.cpp:284: #ifdef SK_SHOW_HAIRCLIP_STATS
I'm fine with these, or fine if we remove all this stats gathering code, since I
at least have not tested it in quite a while.

https://codereview.chromium.org/1943403006/diff/20001/src/core/SkScan_Hairlin...
src/core/SkScan_Hairline.cpp:556: if (rclip.isRect()) {
funny indenting (tabs?)

[reed1, 2016-05-12 13:42:11]

lgtm

[caryclark, 2016-05-12 13:45:21]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2016-05-12 13:45:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943403006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943403006/60001

[commit-bot: I haz the power, 2016-05-12 14:07:08]

Description was changed from

==========
fix hairline clip

Don't remove inner clip if it's non-rectangular.
Add cubic hairline clip code to quad and conic cases.

R=reed@google.com
BUG=skia:5252
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
fix hairline clip

Don't remove inner clip if it's non-rectangular.
Add cubic hairline clip code to quad and conic cases.

R=reed@google.com
BUG=skia:5252
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/4cba202b7162fb5f364235dd29f0bdbd53a8e33c
==========

[commit-bot: I haz the power, 2016-05-12 14:07:09]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/4cba202b7162fb5f364235dd29f0bdbd53a8e33c