Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1943403005:
Removing redundant DCHECK (Closed)
|
Created:
4 years, 7 months ago by ramya.v Modified:
4 years, 7 months ago CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemoving redundant DCHECK
Element is asserted in DCHECK(is[HTML|SVG]ScriptElement(elem)).
separate DCHECK for element is not necessary.
BUG=495194
Committed: https://crrev.com/b8f022a103f638d6b4f9e5853cec7f5f4330b097
Cr-Commit-Position: refs/heads/master@{#392545}
Patch Set 1 #
Messages
Total messages: 19 (8 generated)
ramya.v@samsung.com changed reviewers: + fs@opera.com, srirama.m@samsung.com
PTAL! Thanks
Non-owner LGTM
ramya.v@samsung.com changed reviewers: + tkent@chromium.org
PTAL! Thanks
The CQ bit was checked by fs@opera.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943403005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943403005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ramya.v@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943403005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943403005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ramya.v@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943403005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943403005/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Removing redundant DCHECK Element is asserted in DCHECK(is[HTML|SVG]ScriptElement(elem)). separate DCHECK for element is not necessary. BUG=495194 ========== to ========== Removing redundant DCHECK Element is asserted in DCHECK(is[HTML|SVG]ScriptElement(elem)). separate DCHECK for element is not necessary. BUG=495194 Committed: https://crrev.com/b8f022a103f638d6b4f9e5853cec7f5f4330b097 Cr-Commit-Position: refs/heads/master@{#392545} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b8f022a103f638d6b4f9e5853cec7f5f4330b097 Cr-Commit-Position: refs/heads/master@{#392545} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
