Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1943403004: [turbofan] Implement %_NewObject using FastNewObjectStub. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implement %_NewObject using FastNewObjectStub. The inline allocation sequence in the optimizing compilers cannot deal well with funky types like JSRegExp, which have some magic fields in addition to the inobject properties. In Crankshaft we already use the FastNewObjectStub for %_NewObject in general, so fix TurboFan to the same. Hopefully one day we can kill %_NewObject completely. R=jarin@chromium.org BUG=chromium:609029 LOG=n Committed: https://crrev.com/c3218375c1583ed6f8ed8bc57cc0bac7326e1ab4 Cr-Commit-Position: refs/heads/master@{#36006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +1 line, -9 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-609029.js View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-04 07:09:17 UTC) #1
Benedikt Meurer
Hey Jaro, Quickfix to make Clusterfuzz happy. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-04 07:09:55 UTC) #2
Jarin
lgtm
4 years, 7 months ago (2016-05-04 07:13:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943403004/1
4 years, 7 months ago (2016-05-04 07:14:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 07:33:33 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c3218375c1583ed6f8ed8bc57cc0bac7326e1ab4 Cr-Commit-Position: refs/heads/master@{#36006}
4 years, 7 months ago (2016-05-04 07:35:36 UTC) #8
Benedikt Meurer
4 years, 7 months ago (2016-05-04 11:16:57 UTC) #9
Message was sent while issue was closed.
Hey Jaro,

Quick fix.
Please take a look.

Thanks,
Benedikt

Powered by Google App Engine
This is Rietveld 408576698