Fixed DevTools event-listener breakpoints for PointerEvents.

Fixed DevTools event-listener breakpoints for PointerEvents.

Also added a test with PointerEvent specific expectation, in
the "pointerevent" virtual suite.

BUG=605706
Committed: https://crrev.com/331cbe0e04f124affaec2c52fe38c6f22c7b6c69
Cr-Commit-Position: refs/heads/master@{#391804}

[mustaq, 2016-05-03 15:11:57]

mustaq@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, lushnikov@chromium.org

[mustaq, 2016-05-03 15:11:58]

ptal, retrying crrev.com/1915623002.

IMO, adding the breakpoint tests as a virtual test suite may have been a bad
idea, but I don't see a way to test PointerEvent breakpoints without one. May be
skipping the test altogether is a better idea?!

[lushnikov, 2016-05-04 18:08:36]

can we make a separate test for pointer events and put it under virtual folder
altogether? wdyt?

[mustaq, 2016-05-04 20:14:31]

On 2016/05/04 18:08:36, lushnikov wrote:
> can we make a separate test for pointer events and put it under virtual folder
> altogether? wdyt?

The problem is that other (unchanged) tests are also failing when run in the
virtual suite. E.g. dom-breakpoints.html times out in Mac
(https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...)
only in the virtual test suite. This breaks the understanding that the virtual
test environment is the same (as in the "main test suite") except for the
commandline flags in the config (VirtualTestSuites).

W/o any no clue what's going on here, I think it makes sense to let this simple
CL go ahead w/o a test. ptal.

[lushnikov, 2016-05-04 21:17:48]

Currently, all inspector/sources tests are marked as SLOW. 
Virtual tests, however, do not inherit test expectations from the base tests -
which resulted in virtual/../dom-breakpoints to timeout.

So you should mark virtual/pointerevents/inspector/sources/debugger-breakpoints
as SLOW as well.

Also, let's bring back the event-listener-breakpoints.html test - this will help
to avoid regressing this in future.

This time it should land successfully!

Thanks!

[mustaq, 2016-05-04 21:26:32]

On 2016/05/04 21:17:48, lushnikov wrote:
> Currently, all inspector/sources tests are marked as SLOW. 
> Virtual tests, however, do not inherit test expectations from the base tests -
> which resulted in virtual/../dom-breakpoints to timeout.
> 
> So you should mark
virtual/pointerevents/inspector/sources/debugger-breakpoints
> as SLOW as well.
> 
> Also, let's bring back the event-listener-breakpoints.html test - this will
help
> to avoid regressing this in future.
> 
> This time it should land successfully!
> 
> Thanks!

I see, the SLOW label explains the differences between the test suites, thanks.

Where/how to mark a test as SLOW?

[mustaq, 2016-05-04 21:29:23]

On 2016/05/04 21:26:32, mustaq wrote:
> On 2016/05/04 21:17:48, lushnikov wrote:
> > Currently, all inspector/sources tests are marked as SLOW. 
> > Virtual tests, however, do not inherit test expectations from the base tests
-
> > which resulted in virtual/../dom-breakpoints to timeout.
> > 
> > So you should mark
> virtual/pointerevents/inspector/sources/debugger-breakpoints
> > as SLOW as well.
> > 
> > Also, let's bring back the event-listener-breakpoints.html test - this will
> help
> > to avoid regressing this in future.
> > 
> > This time it should land successfully!
> > 
> > Thanks!
> 
> I see, the SLOW label explains the differences between the test suites,
thanks.
> 
> Where/how to mark a test as SLOW?

Got the answer. I will give it a try.

[mustaq, 2016-05-04 21:36:14]

On 2016/05/04 21:29:23, mustaq wrote:
> On 2016/05/04 21:26:32, mustaq wrote:
> > On 2016/05/04 21:17:48, lushnikov wrote:
> > > Currently, all inspector/sources tests are marked as SLOW. 
> > > Virtual tests, however, do not inherit test expectations from the base
tests
> -
> > > which resulted in virtual/../dom-breakpoints to timeout.
> > > 
> > > So you should mark
> > virtual/pointerevents/inspector/sources/debugger-breakpoints
> > > as SLOW as well.
> > > 
> > > Also, let's bring back the event-listener-breakpoints.html test - this
will
> > help
> > > to avoid regressing this in future.
> > > 
> > > This time it should land successfully!
> > > 
> > > Thanks!
> > 
> > I see, the SLOW label explains the differences between the test suites,
> thanks.
> > 
> > Where/how to mark a test as SLOW?
> 
> Got the answer. I will give it a try.

Done, ptal.

[mustaq, 2016-05-04 21:36:20]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 21:36:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943403002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943403002/40001

[lushnikov, 2016-05-04 23:08:29]

lgtm!

https://codereview.chromium.org/1943403002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1943403002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:211: #crbug.com/608356 [ Linux ]
virtual/pointerevent/inspector/sources/debugger-breakpoints/dom-breakpoints.html
[ Timeout ]
i believe you don't need these entries any more.

https://codereview.chromium.org/1943403002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints.html
(right):

https://codereview.chromium.org/1943403002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints.html:142:
if(window.PointerEvent) {
nit: space after "if"

[commit-bot: I haz the power, 2016-05-05 00:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 00:54:19]

Dry run: This issue passed the CQ dry run.

[mustaq, 2016-05-05 13:53:51]

https://codereview.chromium.org/1943403002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1943403002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:211: #crbug.com/608356 [ Linux ]
virtual/pointerevent/inspector/sources/debugger-breakpoints/dom-breakpoints.html
[ Timeout ]
On 2016/05/04 23:08:29, lushnikov wrote:
> i believe you don't need these entries any more.

You are right, wanted to dry-run first.

https://codereview.chromium.org/1943403002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints.html
(right):

https://codereview.chromium.org/1943403002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints.html:142:
if(window.PointerEvent) {
On 2016/05/04 23:08:29, lushnikov wrote:
> nit: space after "if"

Done.

[mustaq, 2016-05-05 13:54:38]

The CQ bit was checked by mustaq@chromium.org

[mustaq, 2016-05-05 13:54:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1943403002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-05 13:54:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943403002/60001

[commit-bot: I haz the power, 2016-05-05 15:09:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-05 15:10:37]

Description was changed from

==========
Fixed DevTools event-listener breakpoints for PointerEvents.

Also added a test with PointerEvent specific expectation, in
the "pointerevent" virtual suite.

BUG=605706
==========

to

==========
Fixed DevTools event-listener breakpoints for PointerEvents.

Also added a test with PointerEvent specific expectation, in
the "pointerevent" virtual suite.

BUG=605706

Committed: https://crrev.com/331cbe0e04f124affaec2c52fe38c6f22c7b6c69
Cr-Commit-Position: refs/heads/master@{#391804}
==========

[commit-bot: I haz the power, 2016-05-05 15:10:39]

Patchset 4 (id:??) landed as
https://crrev.com/331cbe0e04f124affaec2c52fe38c6f22c7b6c69
Cr-Commit-Position: refs/heads/master@{#391804}