Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1943383003: [interpreter] Always 'continue' loops by jumping forward to end of body. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
Reviewers:
oth, rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Always 'continue' loops by jumping forward to end of body. We sometimes used to continue by jumping _back_ to the condition check at the top of the loop. After my recent generator-related changes, that check is no longer at the loop header, so a continue could create an additional loop. In order to avoid this, we now always set the continue target to be the first instruction following the loop body. BUG= Committed: https://crrev.com/ca5aa3c86ac5d9695046e45a98b00a23cbed5e17 Cr-Commit-Position: refs/heads/master@{#36029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -36 lines) Patch
M src/interpreter/bytecode-generator.cc View 8 chunks +1 line, -9 lines 0 comments Download
M src/interpreter/control-flow-builders.h View 1 chunk +3 lines, -8 lines 0 comments Download
M src/interpreter/control-flow-builders.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BasicLoops.golden View 7 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
neis
PTAL. Note that in the case that we eventually want to support 'continue' inside do-expressions, ...
4 years, 7 months ago (2016-05-04 13:30:38 UTC) #3
rmcilroy
Nice, LGTM assuming it works for Orion. Thanks.
4 years, 7 months ago (2016-05-04 15:11:11 UTC) #4
oth
Super, lgtm, thanks!
4 years, 7 months ago (2016-05-04 15:21:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943383003/1
4 years, 7 months ago (2016-05-04 15:25:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 15:56:21 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 15:57:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca5aa3c86ac5d9695046e45a98b00a23cbed5e17
Cr-Commit-Position: refs/heads/master@{#36029}

Powered by Google App Engine
This is Rietveld 408576698