Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1943383002: Add display_compositor unittests into components_unittests (Closed)

Created:
4 years, 7 months ago by Peng
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add display_compositor unittests into components_unittests BUG=607236 Committed: https://crrev.com/75070638ecd24005a4c78d410ac56915ae17a6b6 Cr-Commit-Position: refs/heads/master@{#391553}

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Update #

Patch Set 4 : Update #

Total comments: 6

Patch Set 5 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -5 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 4 chunks +10 lines, -0 lines 0 comments Download
M components/display_compositor.gypi View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M components/display_compositor/BUILD.gn View 1 2 3 4 1 chunk +35 lines, -1 line 0 comments Download
M components/display_compositor/gl_helper_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/display_compositor/yuv_readback_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Peng
Hi Fady, PTAL. Thanks.
4 years, 7 months ago (2016-05-03 18:00:11 UTC) #2
Fady Samuel
https://codereview.chromium.org/1943383002/diff/60001/components/display_compositor/BUILD.gn File components/display_compositor/BUILD.gn (left): https://codereview.chromium.org/1943383002/diff/60001/components/display_compositor/BUILD.gn#oldcode38 components/display_compositor/BUILD.gn:38: "display_compositor_test_suite.cc", Do we still need these files? https://codereview.chromium.org/1943383002/diff/60001/components/display_compositor/gl_helper_unittest.cc File ...
4 years, 7 months ago (2016-05-03 18:03:44 UTC) #3
Peng
https://codereview.chromium.org/1943383002/diff/60001/components/display_compositor/BUILD.gn File components/display_compositor/BUILD.gn (left): https://codereview.chromium.org/1943383002/diff/60001/components/display_compositor/BUILD.gn#oldcode38 components/display_compositor/BUILD.gn:38: "display_compositor_test_suite.cc", On 2016/05/03 18:03:44, Fady Samuel wrote: > Do ...
4 years, 7 months ago (2016-05-03 18:10:36 UTC) #4
Fady Samuel
lgtm
4 years, 7 months ago (2016-05-03 18:27:21 UTC) #5
Peng
Hi jochen, PTAL. Thanks.
4 years, 7 months ago (2016-05-03 18:29:37 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-04 10:53:50 UTC) #8
Peng
+ben for BUILD.gn Ben, PATL. Thanks.
4 years, 7 months ago (2016-05-04 14:10:23 UTC) #10
Ben Goodger (Google)
lgtm
4 years, 7 months ago (2016-05-04 16:47:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943383002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943383002/80001
4 years, 7 months ago (2016-05-04 17:05:55 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-04 17:33:21 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 17:35:58 UTC) #17
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/75070638ecd24005a4c78d410ac56915ae17a6b6
Cr-Commit-Position: refs/heads/master@{#391553}

Powered by Google App Engine
This is Rietveld 408576698