src/typing-asm.cc - Issue 1943373002: [wasm] Disallow runtime calls in asm.js modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing-asm.cc

Issue 1943373002: [wasm] Disallow runtime calls in asm.js modules. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typing-asm.cc

diff --git a/src/typing-asm.cc b/src/typing-asm.cc

index 942b57b66b72eaefd6915f5a879a3df4ff7dee0c..771d255b81a5ba81eb1865ac49cff3e370f8b8f0 100644

--- a/src/typing-asm.cc

+++ b/src/typing-asm.cc

@@ -1071,7 +1071,7 @@ void AsmTyper::VisitCallNew(CallNew* expr) {

void AsmTyper::VisitCallRuntime(CallRuntime* expr) {

- // Allow runtime calls for now.

+ FAIL(expr, "runtime call not allowed");

}

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-592352.js » ('j') | no next file with comments »