Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1943373002: [wasm] Disallow runtime calls in asm.js modules. (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Disallow runtime calls in asm.js modules. R=ahaas@chromium.org,bradnelson@chromium.org BUG=chromium:592352 LOG=Y Committed: https://crrev.com/d622c3a8bdb2628820c3144d3f893ef4a52c9542 Cr-Commit-Position: refs/heads/master@{#35992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/typing-asm.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-592352.js View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 7 months ago (2016-05-03 14:59:12 UTC) #1
bradnelson
lgtm
4 years, 7 months ago (2016-05-03 15:51:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943373002/1
4 years, 7 months ago (2016-05-03 15:51:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 15:55:47 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 15:57:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d622c3a8bdb2628820c3144d3f893ef4a52c9542
Cr-Commit-Position: refs/heads/master@{#35992}

Powered by Google App Engine
This is Rietveld 408576698