Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1943353002: Fix ServiceWorker bg paint metric. (Closed)

Created:
4 years, 7 months ago by Bryan McQuade
Modified:
4 years, 7 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ServiceWorker bg paint metric. BUG=608727 Committed: https://crrev.com/e8cdad1a9d87eac29fbdbf7e376a89c4cd9189ba Cr-Commit-Position: refs/heads/master@{#391241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc View 1 chunk +11 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bryan McQuade
PTAL
4 years, 7 months ago (2016-05-03 14:56:54 UTC) #2
Charlie Harrison
Yeah, lgtm. Thanks for catching this case as well.
4 years, 7 months ago (2016-05-03 14:58:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943353002/1
4 years, 7 months ago (2016-05-03 15:01:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 15:36:40 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 15:37:57 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e8cdad1a9d87eac29fbdbf7e376a89c4cd9189ba
Cr-Commit-Position: refs/heads/master@{#391241}

Powered by Google App Engine
This is Rietveld 408576698